Bug 101849 - Don't detach from shared ElementAttributeData when overwriting attribute with identical value.
Summary: Don't detach from shared ElementAttributeData when overwriting attribute with...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-10 14:04 PST by Andreas Kling
Modified: 2012-11-12 14:47 PST (History)
3 users (show)

See Also:

Attachments
Patch (3.54 KB, patch)
2012-11-10 14:05 PST, Andreas Kling 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2012-11-10 14:04:20 PST 
Copy-on-write when nothing actually changes is unfortunate. Let's avoid it.
Comment 1 Andreas Kling 2012-11-10 14:05:15 PST 
Created attachment 173472 [details]
Patch
Comment 2 WebKit Review Bot 2012-11-10 14:36:17 PST 
Comment on attachment 173472 [details]
Patch

Clearing flags on attachment: 173472

Committed r134163: <http://trac.webkit.org/changeset/134163>
Comment 3 WebKit Review Bot 2012-11-10 14:36:21 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 Ojan Vafai 2012-11-11 21:12:56 PST 
Nice change. This was also a ~7% win on Dromaeo DOMCore attr setAttribute. http://build.chromium.org/f/chromium/perf/chromium-rel-win7-webkit/dromaeo_domcoreattr/report.html?rev=167406&graph=dom_attr_setAttribute&trace=score&history=50
Comment 5 Andreas Kling 2012-11-12 14:47:20 PST 
(In reply to comment #4)
> Nice change. This was also a ~7% win on Dromaeo DOMCore attr setAttribute. http://build.chromium.org/f/chromium/perf/chromium-rel-win7-webkit/dromaeo_domcoreattr/report.html?rev=167406&graph=dom_attr_setAttribute&trace=score&history=50

Oh awesome! Thanks for letting me know :)