Bug 103184 - Put computed style 'font-family' values in the CSSValuePool.
Summary: Put computed style 'font-family' values in the CSSValuePool.
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on: 103196 103218
Blocks:
  Show dependency tree / graph
 
Reported: 2012-11-24 11:32 PST by Andreas Kling
Modified: 2014-08-19 16:13 PDT (History)
7 users (show)

See Also:

Attachments
Patch (2.49 KB, patch)
2012-11-24 11:39 PST, Andreas Kling 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2012-11-24 11:32:25 PST 
They're already cached in the parsing stage so there's no sense in constructing new objects when exposing them through CSSComputedStyleDeclaration.
Comment 1 Andreas Kling 2012-11-24 11:39:47 PST 
Created attachment 175862 [details]
Patch
Comment 2 WebKit Review Bot 2012-11-24 12:32:12 PST 
Comment on attachment 175862 [details]
Patch

Clearing flags on attachment: 175862

Committed r135656: <http://trac.webkit.org/changeset/135656>
Comment 3 WebKit Review Bot 2012-11-24 12:32:15 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 Csaba Osztrogonác 2012-11-25 00:39:56 PST 
(In reply to comment #2)
> (From update of attachment 175862 [details])
> Clearing flags on attachment: 175862
> 
> Committed r135656: <http://trac.webkit.org/changeset/135656>

It made 2 tests crash on Qt, see https://bugs.webkit.org/show_bug.cgi?id=103196 for details.
Comment 5 WebKit Review Bot 2012-11-25 23:40:59 PST 
Re-opened since this is blocked by bug 103218
Comment 6 Andreas Kling 2014-08-19 16:13:12 PDT 
This is not a valid optimization, since compute style values are exposed in CSSOM.