Bug 105336 - [Mac] Build Phase check-* scripts should use CONTENTS_FOLDER_PATH instead of SHALLOW_BUNDLE
Summary: [Mac] Build Phase check-* scripts should use CONTENTS_FOLDER_PATH instead of ...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-18 12:21 PST by Joseph Pecoraro
Modified: 2016-09-07 21:50 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2012-12-18 12:21:07 PST 
Instead of manually building the path to the Framework / Headers / PrivateHeaders directories by checking SHALLOW_BUNDLE we can take advantage of CONTENTS_FOLDER_PATH. Scripts that should probably be updated:

    shell> grep --files-with-matches -R SHALLOW_BUNDLE Tools/Scripts
    Tools/Scripts/check-for-inappropriate-files-in-framework
    Tools/Scripts/check-for-inappropriate-macros-in-external-headers
    Tools/Scripts/check-for-webkit-framework-include-consistency
    Tools/Scripts/webkitruby/check-for-inappropriate-macros-in-external-headers-tests/run-test.rb