Bug 107645 - Pass CSSSelector pointers around as const after parsing stage.
Summary: Pass CSSSelector pointers around as const after parsing stage.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-23 00:47 PST by Andreas Kling
Modified: 2013-01-23 02:27 PST (History)
9 users (show)

See Also:

Attachments
atchP (34.22 KB, patch)
2013-01-23 00:51 PST, Andreas Kling 		eflews.bot: commit-queue-
Details | Formatted Diff | Diff
Please, Shadow DOM, please. (35.99 KB, patch)
2013-01-23 01:38 PST, Andreas Kling 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-01-23 00:47:53 PST 
CSSSelector contents should never change after CSSParser is done with them, so we should hand them out as const pointers everywhere else.
Comment 1 Andreas Kling 2013-01-23 00:51:01 PST 
Created attachment 184173 [details]
atchP
Comment 2 EFL EWS Bot 2013-01-23 01:05:22 PST 
Comment on attachment 184173 [details]
atchP

Attachment 184173 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/16063494
Comment 3 WebKit Review Bot 2013-01-23 01:13:49 PST 
Comment on attachment 184173 [details]
atchP

Attachment 184173 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16067263
Comment 4 Peter Beverloo (cr-android ews) 2013-01-23 01:30:07 PST 
Comment on attachment 184173 [details]
atchP

Attachment 184173 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/16073120
Comment 5 Andreas Kling 2013-01-23 01:38:34 PST 
Created attachment 184179 [details]
Please, Shadow DOM, please.
Comment 6 WebKit Review Bot 2013-01-23 02:27:33 PST 
Comment on attachment 184179 [details]
Please, Shadow DOM, please.

Clearing flags on attachment: 184179

Committed r140530: <http://trac.webkit.org/changeset/140530>
Comment 7 WebKit Review Bot 2013-01-23 02:27:37 PST 
All reviewed patches have been landed.  Closing bug.