Bug 107809 - Add CSSSelectorList::isValid().
Summary: Add CSSSelectorList::isValid().
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-24 04:17 PST by Andreas Kling
Modified: 2013-01-24 05:15 PST (History)
6 users (show)

See Also:


Attachments
Low-value refactoring (4.15 KB, patch)
2013-01-24 04:26 PST, Andreas Kling
koivisto: review+
Details | Formatted Diff | Diff
Moon lander (4.15 KB, patch)
2013-01-24 04:31 PST, Andreas Kling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-01-24 04:17:51 PST
Users of CSSSelectorList shouldn't have to know that first()==0 means the list is invalid.
Comment 1 Andreas Kling 2013-01-24 04:26:01 PST
Created attachment 184461 [details]
Low-value refactoring
Comment 2 WebKit Review Bot 2013-01-24 04:29:46 PST
Attachment 184461 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/css/CSSPageRule.cpp', u'Source/WebCore/css/CSSSelectorList.h', u'Source/WebCore/css/CSSStyleRule.cpp', u'Source/WebCore/html/shadow/HTMLContentElement.cpp', u'Source/WebCore/inspector/InspectorStyleSheet.cpp']" exit_code: 1
Source/WebCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Andreas Kling 2013-01-24 04:31:58 PST
Created attachment 184463 [details]
Moon lander
Comment 4 WebKit Review Bot 2013-01-24 04:35:37 PST
Comment on attachment 184463 [details]
Moon lander

Rejecting attachment 184463 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-04', 'apply-attachment', '--no-update', '--non-interactive', 184463, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:
e left on device
patch: **** Can't create file /tmp/ppodQ2EK : No space left on device
patch: **** Can't create file /tmp/ppZ7RmQK : No space left on device
patch: **** Can't create file /tmp/ppRZvAFL : No space left on device
patch: **** Can't create file /tmp/ppDBElPL : No space left on device
patch: **** Can't create file /tmp/ppR3K8qL : No space left on device

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', '--force']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/16082644
Comment 5 Andreas Kling 2013-01-24 05:15:39 PST
Comment on attachment 184463 [details]
Moon lander

Clearing flags on attachment: 184463

Committed r140677: <http://trac.webkit.org/changeset/140677>
Comment 6 Andreas Kling 2013-01-24 05:15:47 PST
All reviewed patches have been landed.  Closing bug.