Bug 108749 - Check PrivateHeaders/JSBasePrivate.h for inappropriate macros
Summary: Check PrivateHeaders/JSBasePrivate.h for inappropriate macros
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords:
Depends on:
Blocks: 105341
  Show dependency tree / graph
 
Reported: 2013-02-02 05:01 PST by David Kilzer (:ddkilzer)
Modified: 2013-02-04 11:03 PST (History)
4 users (show)

See Also:

Attachments
Patch v1 (1.89 KB, patch)
2013-02-02 05:03 PST, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2013-02-02 05:01:22 PST 
* JavaScriptCore.xcodeproj/project.pbxproj: Add
PrivateHeaders/JSBasePrivate.h to list of headers to check in
"Check for Inappropriate Macros in External Headers" build phase
script.
Comment 1 David Kilzer (:ddkilzer) 2013-02-02 05:03:36 PST 
Created attachment 186223 [details]
Patch v1
Comment 2 Build Bot 2013-02-02 06:08:30 PST 
Comment on attachment 186223 [details]
Patch v1

Attachment 186223 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/16340761
Comment 3 David Kilzer (:ddkilzer) 2013-02-02 08:41:50 PST 
(In reply to comment #2)
> (From update of attachment 186223 [details])
> Attachment 186223 [details] did not pass win-ews (win):
> Output: http://queues.webkit.org/results/16340761

1>..\cg\ImageDiffCG.cpp(37) : fatal error C1083: Cannot open include file: 'wtf/Platform.h': No such file or directory

Hmm...could this patch have caused that?
Comment 4 David Kilzer (:ddkilzer) 2013-02-02 09:12:20 PST 
Comment on attachment 186223 [details]
Patch v1

(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 186223 [details] [details])
> > Attachment 186223 [details] [details] did not pass win-ews (win):
> > Output: http://queues.webkit.org/results/16340761
> 
> 1>..\cg\ImageDiffCG.cpp(37) : fatal error C1083: Cannot open include file: 'wtf/Platform.h': No such file or directory
> 
> Hmm...could this patch have caused that?

Nope.
Comment 5 Joseph Pecoraro 2013-02-04 10:45:35 PST 
Comment on attachment 186223 [details]
Patch v1

r=me
Comment 6 WebKit Review Bot 2013-02-04 11:03:20 PST 
Comment on attachment 186223 [details]
Patch v1

Clearing flags on attachment: 186223

Committed r141786: <http://trac.webkit.org/changeset/141786>
Comment 7 WebKit Review Bot 2013-02-04 11:03:25 PST 
All reviewed patches have been landed.  Closing bug.