Bug 109366 - RenderStyle should use copy-on-write inheritance for NinePieceImage.
Summary: RenderStyle should use copy-on-write inheritance for NinePieceImage.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords: Performance
Depends on:
Blocks:
 
Reported: 2013-02-09 18:48 PST by Andreas Kling
Modified: 2013-02-10 08:06 PST (History)
6 users (show)

See Also:


Attachments
Patch (17.39 KB, patch)
2013-02-09 19:06 PST, Andreas Kling
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Patch (17.76 KB, patch)
2013-02-09 22:47 PST, Andreas Kling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-02-09 18:48:47 PST
Last night I had a dream about Antti telling me NinePieceImage should use copy-on-write inheritance.
Comment 1 Andreas Kling 2013-02-09 19:06:14 PST
Created attachment 187454 [details]
Patch
Comment 2 WebKit Review Bot 2013-02-09 19:15:35 PST
Attachment 187454 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/rendering/style/NinePieceImage.cpp', u'Source/WebCore/rendering/style/NinePieceImage.h', u'Source/WebCore/rendering/style/RenderStyle.cpp', u'Source/WebCore/rendering/style/RenderStyle.h']" exit_code: 1
Source/WebCore/rendering/style/NinePieceImage.cpp:80:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/rendering/style/NinePieceImage.cpp:81:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/rendering/style/NinePieceImage.cpp:82:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/rendering/style/NinePieceImage.cpp:83:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/rendering/style/NinePieceImage.cpp:84:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/rendering/style/NinePieceImage.cpp:85:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/rendering/style/NinePieceImage.h:62:  The parameter name "image" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 7 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Review Bot 2013-02-09 20:23:44 PST
Comment on attachment 187454 [details]
Patch

Attachment 187454 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16475593

New failing tests:
animations/cross-fade-border-image-source.html
Comment 4 Andreas Kling 2013-02-09 20:24:24 PST
Comment on attachment 187454 [details]
Patch

Huh.
Comment 5 WebKit Review Bot 2013-02-09 21:22:27 PST
Comment on attachment 187454 [details]
Patch

Attachment 187454 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16474621

New failing tests:
animations/cross-fade-border-image-source.html
Comment 6 Andreas Kling 2013-02-09 22:47:02 PST
Created attachment 187464 [details]
Patch
Comment 7 WebKit Review Bot 2013-02-10 08:06:22 PST
Comment on attachment 187464 [details]
Patch

Clearing flags on attachment: 187464

Committed r142404: <http://trac.webkit.org/changeset/142404>
Comment 8 WebKit Review Bot 2013-02-10 08:06:28 PST
All reviewed patches have been landed.  Closing bug.