Bug 109529 - Better names for ElementAttributeData & subclasses.
Summary: Better names for ElementAttributeData & subclasses.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks: 109505
  Show dependency tree / graph
 
Reported: 2013-02-11 17:48 PST by Andreas Kling
Modified: 2013-02-13 13:51 PST (History)
15 users (show)

See Also:

Attachments
Patch (76.33 KB, patch)
2013-02-11 18:05 PST, Andreas Kling 		webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Patch (77.01 KB, patch)
2013-02-11 19:11 PST, Andreas Kling 		webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Patch (75.04 KB, patch)
2013-02-13 10:05 PST, Andreas Kling 		no flags Details | Formatted Diff | Diff
Patch (75.04 KB, patch)
2013-02-13 11:46 PST, Andreas Kling 		no flags Details | Formatted Diff | Diff
Patch (74.95 KB, patch)
2013-02-13 12:20 PST, Andreas Kling 		koivisto: review+
Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-02-11 17:48:49 PST 
Here's what I'm thinking:

ElementAttributeData => ElementData
MutableElementAttributeData => PrivateElementAttributeData
ImmutableElementAttributeDat a=> SharableElementAttributeData

Element::attributeData() -> Element::elementData()
Element::mutableAttributeData() => Element::ensurePrivateElementData()
Comment 1 Andreas Kling 2013-02-11 17:52:41 PST 
MutableElementAttributeData => PrivateElementData
ImmutableElementAttributeData => SharableElementData

Is what I meant, duh.
Comment 2 Andreas Kling 2013-02-11 18:05:40 PST 
Created attachment 187739 [details]
Patch
Comment 3 WebKit Review Bot 2013-02-11 18:39:52 PST 
Comment on attachment 187739 [details]
Patch

Attachment 187739 [details] did not pass cr-linux-debug-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16487609
Comment 4 Andreas Kling 2013-02-11 19:11:14 PST 
Created attachment 187753 [details]
Patch
Comment 5 WebKit Review Bot 2013-02-11 21:15:33 PST 
Comment on attachment 187753 [details]
Patch

Attachment 187753 [details] did not pass cr-linux-debug-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16489683
Comment 6 Andreas Kling 2013-02-11 21:21:04 PST 
Comment on attachment 187753 [details]
Patch

Actually, let's move stuff to Element.h/cpp first so we get as much version control history as possible.
Comment 7 Andreas Kling 2013-02-13 10:05:03 PST 
Created attachment 188108 [details]
Patch
Comment 8 Andreas Kling 2013-02-13 11:46:09 PST 
Created attachment 188134 [details]
Patch
Comment 9 Antti Koivisto 2013-02-13 11:51:20 PST 
Comment on attachment 188134 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=188134&action=review

> Source/WebCore/ChangeLog:17
> +        - MutableElementAttributeData => PrivateElementData

"Private" is bit overloaded and does not pair that well with "shareable". Maybe "unique"?
Comment 10 Andreas Kling 2013-02-13 12:20:04 PST 
Created attachment 188144 [details]
Patch

Yeah okay, "Unique" is nice.
Comment 11 Andreas Kling 2013-02-13 13:51:50 PST 
Committed r142791: <http://trac.webkit.org/changeset/142791>