Bug 109610 - Move ElementAttributeData into Element.cpp/h
Summary: Move ElementAttributeData into Element.cpp/h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks: 109505
  Show dependency tree / graph
 
Reported: 2013-02-12 13:40 PST by Andreas Kling
Modified: 2013-02-12 17:45 PST (History)
8 users (show)

See Also:

Attachments
Patch (44.91 KB, patch)
2013-02-12 13:46 PST, Andreas Kling 		andersca: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (deleted)
2013-02-12 15:53 PST, Andreas Kling 		kling: commit-queue+
Details | Formatted Diff | Diff
Patch for landing (45.93 KB, patch)
2013-02-12 16:18 PST, Andreas Kling 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-02-12 13:40:52 PST 
ElementAttributeData is really just a slightly-less-than-dumb container that holds data for Element.
I envision a future where Element is the only client of this class. As a first step, let's move the class into Element.h/cpp.
Comment 1 Andreas Kling 2013-02-12 13:46:19 PST 
Created attachment 187925 [details]
Patch
Comment 2 WebKit Review Bot 2013-02-12 14:29:44 PST 
Comment on attachment 187925 [details]
Patch

Attachment 187925 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16513403
Comment 3 WebKit Review Bot 2013-02-12 14:50:06 PST 
Comment on attachment 187925 [details]
Patch

Attachment 187925 [details] did not pass cr-linux-debug-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16444492
Comment 4 Peter Beverloo (cr-android ews) 2013-02-12 15:10:56 PST 
Comment on attachment 187925 [details]
Patch

Attachment 187925 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/16440447
Comment 5 Andreas Kling 2013-02-12 15:53:50 PST 
Created attachment 187953 [details]
Patch for landing
Comment 6 Andreas Kling 2013-02-12 16:18:34 PST 
Created attachment 187958 [details]
Patch for landing
Comment 7 WebKit Review Bot 2013-02-12 17:45:33 PST 
Comment on attachment 187958 [details]
Patch for landing

Clearing flags on attachment: 187958

Committed r142698: <http://trac.webkit.org/changeset/142698>
Comment 8 WebKit Review Bot 2013-02-12 17:45:38 PST 
All reviewed patches have been landed.  Closing bug.