Bug 110033 - Element: Devirtualize attribute synchronization functions.
Summary: Element: Devirtualize attribute synchronization functions.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-16 15:16 PST by Andreas Kling
Modified: 2013-02-16 15:36 PST (History)
1 user (show)

See Also:


Attachments
Patch (8.25 KB, patch)
2013-02-16 15:20 PST, Andreas Kling
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-02-16 15:16:03 PST
There's no reason for Element::updateStyleAttribute() and Element::updateAnimatedSVGAttribute() to be virtual.
Comment 1 Andreas Kling 2013-02-16 15:20:45 PST
Created attachment 188731 [details]
Patch
Comment 2 Darin Adler 2013-02-16 15:27:27 PST
Comment on attachment 188731 [details]
Patch

Not sure it’s ideal to have “synchronize attribute” as the name for both the smart function and the one that should only be called if the attribute is known dirty. I guess I am the one who told you to remove “if needed”, and I still stand by that.
Comment 3 Andreas Kling 2013-02-16 15:36:20 PST
Committed r143114: <http://trac.webkit.org/changeset/143114>