Bug 110046 - Remove multi-threading gunk from WebKit2's PluginInfoStore.
Summary: Remove multi-threading gunk from WebKit2's PluginInfoStore.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on: 110053
Blocks:
  Show dependency treegraph
 
Reported: 2013-02-16 21:11 PST by Andreas Kling
Modified: 2013-02-17 07:18 PST (History)
5 users (show)

See Also:


Attachments
Patch (7.41 KB, patch)
2013-02-16 21:21 PST, Andreas Kling
ap: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-02-16 21:11:36 PST
There's some cruft left behind after removing the multi-threading code from WK2's PluginInfoStore.
Comment 1 Andreas Kling 2013-02-16 21:21:22 PST
Created attachment 188753 [details]
Patch
Comment 2 Build Bot 2013-02-16 21:50:30 PST
Comment on attachment 188753 [details]
Patch

Attachment 188753 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://queues.webkit.org/results/16590745

New failing tests:
media/video-controls-captions-trackmenu.html
Comment 3 Andreas Kling 2013-02-16 22:03:29 PST
Committed r143124: <http://trac.webkit.org/changeset/143124>
Comment 4 Chris Dumez 2013-02-17 07:06:54 PST
The output of plugins/plugin-javascript-access.html changed after this patch it seems:
--- /home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/layout-test-results/plugins/plugin-javascript-access-expected.txt
+++ /home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/layout-test-results/plugins/plugin-javascript-access-actual.txt
@@ -1,3 +1,37 @@
+Name: WebKit Test PlugIn
+
+Description: Simple Netscape® plug-in that handles test content for WebKit
+
+Filename: libTestNetscapePlugin.so
+
+Mime Types:
+
+Type: application/x-webkit-test-netscape
+
+Description: test netscape content
+
+Suffixes: testnetscape
+
+
+Plugin.item() works.
+
+Plugin.namedItem() works.
+
+Type: image/png
+
+Description: png image
+
+Suffixes: png
+
+
+Plugin.item() works.
+
+Plugin.namedItem() works.
+
+PluginArray.item() works.
+
+PluginArray.namedItem() works.
+
 Name: WebKit Test PlugIn
 
 Description: Simple Netscape® plug-in that handles test content for WebKit
@@ -41,3 +75,13 @@
 MimeTypeArray.item() works.
 
 MimeTypeArray.namedItem() works.
+
+Type: application/x-webkit-test-netscape
+
+Description: test netscape content
+
+Suffixes: testnetscape
+
+MimeTypeArray.item() works.
+
+MimeTypeArray.namedItem() works.

Based on the patch description, I would not expect the behavior to change. Any idea why this happens?
Comment 5 Chris Dumez 2013-02-17 07:18:19 PST
I uploaded a fix for the regression at Bug 110053.