Bug 110598 - Attr: Simplify modification callbacks.
Summary: Attr: Simplify modification callbacks.
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on: 113530
Blocks:
  Show dependency treegraph
 
Reported: 2013-02-22 05:37 PST by Andreas Kling
Modified: 2013-03-28 12:38 PDT (History)
5 users (show)

See Also:


Attachments
Proposed patch (7.41 KB, patch)
2013-02-22 05:38 PST, Andreas Kling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-02-22 05:37:21 PST
Attr is a friend class of Element and does some pretty hairy stuff to invoke attribute modification callbacks.
This could easily be cleaned up.
Comment 1 Andreas Kling 2013-02-22 05:38:14 PST
Created attachment 189756 [details]
Proposed patch
Comment 2 WebKit Review Bot 2013-02-22 20:49:07 PST
Comment on attachment 189756 [details]
Proposed patch

Clearing flags on attachment: 189756

Committed r143834: <http://trac.webkit.org/changeset/143834>
Comment 3 WebKit Review Bot 2013-02-22 20:49:10 PST
All reviewed patches have been landed.  Closing bug.
Comment 4 WebKit Review Bot 2013-03-28 12:38:54 PDT
Re-opened since this is blocked by bug 113530