Bug 111269 - JSC_OBJC_API_ENABLED should be removed from FeatureDefines.h
Summary: JSC_OBJC_API_ENABLED should be removed from FeatureDefines.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-03 09:10 PST by Mark Hahnenberg
Modified: 2013-03-04 13:13 PST (History)
8 users (show)

See Also:

Attachments
1st take (1.64 KB, patch)
2013-03-03 14:01 PST, Laszlo Gombos 		buildbot: commit-queue-
Details | Formatted Diff | Diff
fix max builds (2.83 KB, patch)
2013-03-03 17:50 PST, Laszlo Gombos 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2013-03-03 09:10:09 PST 
From bug 110291:

"This flag was originally added to FeatureDefines.h so that it could be used in WebCore.exp.in to determine whether or not we should be exporting certain symbols based on whether the WebKit-related portion of the JSC ObjC API was enabled, but it turned out conditionally including certain symbols didn't work when building fat binaries, so it's not even necessary any more.

tl;dr: removing JSC_OBJC_API_ENABLED from FeatureDefines.h is a good idea."
Comment 1 Laszlo Gombos 2013-03-03 14:01:05 PST 
Created attachment 191143 [details]
1st take
Comment 2 Build Bot 2013-03-03 14:59:53 PST 
Comment on attachment 191143 [details]
1st take

Attachment 191143 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-commit-queue.appspot.com/results/16862955
Comment 3 Build Bot 2013-03-03 15:26:33 PST 
Comment on attachment 191143 [details]
1st take

Attachment 191143 [details] did not pass mac-ews (mac):
Output: http://webkit-commit-queue.appspot.com/results/16911184
Comment 4 Build Bot 2013-03-03 16:25:23 PST 
Comment on attachment 191143 [details]
1st take

Attachment 191143 [details] did not pass mac-ews (mac):
Output: http://webkit-commit-queue.appspot.com/results/16910317
Comment 5 Laszlo Gombos 2013-03-03 17:50:33 PST 
Created attachment 191157 [details]
fix max builds
Comment 6 Laszlo Gombos 2013-03-04 06:51:31 PST 
(In reply to comment #5)
> Created an attachment (id=191157) [details]

> fix max builds

I mean mac builds.
Comment 7 Mark Hahnenberg 2013-03-04 12:42:23 PST 
Comment on attachment 191157 [details]
fix max builds

r=me. Thanks for tackling this patch!
Comment 8 WebKit Review Bot 2013-03-04 13:13:34 PST 
Comment on attachment 191157 [details]
fix max builds

Clearing flags on attachment: 191157

Committed r144662: <http://trac.webkit.org/changeset/144662>
Comment 9 WebKit Review Bot 2013-03-04 13:13:39 PST 
All reviewed patches have been landed.  Closing bug.