Bug 111292 - Web Inspector: touchmove not emulated inside iframe
Summary: Web Inspector: touchmove not emulated inside iframe
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Alexander Pavlov (apavlov)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-04 01:04 PST by Alexander Pavlov (apavlov)
Modified: 2013-03-04 01:38 PST (History)
8 users (show)

See Also:

Attachments
Patch (5.63 KB, patch)
2013-03-04 01:11 PST, Alexander Pavlov (apavlov) 		vsevik: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Pavlov (apavlov) 2013-03-04 01:04:03 PST 
Steps to reproduce the problem:
1. Turn "Emulate touch events" on from devtools / cog / overrides.
2. Go to http://codepen.io/jussi-kalliokoski/pen/hLBID .
3. Hold mouse down over the element containing the text.
4. Move the mouse while holding the mouse button down.

What is the expected behavior?
The console should log that the touchmove event occurred.

What went wrong?
Only touchstart and touchend get logged.

Upstreaming https://code.google.com/p/chromium/issues/detail?id=178714
Comment 1 Alexander Pavlov (apavlov) 2013-03-04 01:11:44 PST 
Created attachment 191170 [details]
Patch
Comment 2 Vsevolod Vlasov 2013-03-04 01:31:26 PST 
Comment on attachment 191170 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=191170&action=review

> Source/WebCore/page/EventHandler.cpp:1631
> +    // FIXME: this should be moved elsewhere to also be able to dispatch touchcancel events.

Isn't this comment obsolete?

> Source/WebCore/page/EventHandler.cpp:1632
> +    bool defaultPrevented = dispatchSyntheticTouchEventIfEnabled(mouseEvent);

if (dispatchSyntheticTouchEventIfEnabled(mouseEvent))
    return true;
Comment 3 Alexander Pavlov (apavlov) 2013-03-04 01:38:47 PST 
Committed r144608: <http://trac.webkit.org/changeset/144608>