Bug 111943 - SVGDocumentExtensions should use OwnPtr for pending resource maps.
Summary: SVGDocumentExtensions should use OwnPtr for pending resource maps.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-10 10:50 PDT by Andreas Kling
Modified: 2013-03-10 14:03 PDT (History)
12 users (show)

See Also:

Attachments
Patch (7.18 KB, patch)
2013-03-10 10:51 PDT, Andreas Kling 		andersca: review+
webkit-ews: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (7.44 KB, patch)
2013-03-10 13:43 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-03-10 10:50:42 PDT 
SVGDocumentExtensions should use OwnPtr for pending resource maps.
Comment 1 Andreas Kling 2013-03-10 10:51:25 PDT 
Created attachment 192381 [details]
Patch
Comment 2 Early Warning System Bot 2013-03-10 11:00:25 PDT 
Comment on attachment 192381 [details]
Patch

Attachment 192381 [details] did not pass qt-ews (qt):
Output: http://webkit-commit-queue.appspot.com/results/17024104
Comment 3 Early Warning System Bot 2013-03-10 11:01:07 PDT 
Comment on attachment 192381 [details]
Patch

Attachment 192381 [details] did not pass qt-wk2-ews (qt):
Output: http://webkit-commit-queue.appspot.com/results/17163030
Comment 4 WebKit Review Bot 2013-03-10 11:01:47 PDT 
Comment on attachment 192381 [details]
Patch

Attachment 192381 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17124081
Comment 5 EFL EWS Bot 2013-03-10 11:05:05 PDT 
Comment on attachment 192381 [details]
Patch

Attachment 192381 [details] did not pass efl-ews (efl):
Output: http://webkit-commit-queue.appspot.com/results/17162025
Comment 6 Peter Beverloo (cr-android ews) 2013-03-10 11:10:40 PDT 
Comment on attachment 192381 [details]
Patch

Attachment 192381 [details] did not pass cr-android-ews (chromium-android):
Output: http://webkit-commit-queue.appspot.com/results/17017862
Comment 7 Dirk Schulze 2013-03-10 11:16:59 PDT 
I would like to ask you t wait till one of the SVG folks 2nd the patch before landing. thanks.
Comment 8 WebKit Review Bot 2013-03-10 11:20:09 PDT 
Comment on attachment 192381 [details]
Patch

Attachment 192381 [details] did not pass cr-linux-debug-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17131094
Comment 9 Philip Rogers 2013-03-10 13:16:04 PDT 
Except for the compile error, this looks good. I've been meaning to make the same change for some time :)
Comment 10 Andreas Kling 2013-03-10 13:43:34 PDT 
Created attachment 192384 [details]
Patch for landing

Fixed the 0/nullptr build failure. Anders also requested that I use HashMap::AddResult instead of the awkward ValueType& foo = add().iterator->value; idiom.
Comment 11 WebKit Review Bot 2013-03-10 14:02:55 PDT 
Comment on attachment 192384 [details]
Patch for landing

Clearing flags on attachment: 192384

Committed r145333: <http://trac.webkit.org/changeset/145333>
Comment 12 WebKit Review Bot 2013-03-10 14:03:00 PDT 
All reviewed patches have been landed.  Closing bug.