Bug 112158 - [Qt][WK2] Remove the broken QWebDownloadItem lifetime management code
Summary: [Qt][WK2] Remove the broken QWebDownloadItem lifetime management code
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jocelyn Turcotte
URL:
Keywords:
Depends on: 112155
Blocks: 112159
  Show dependency tree / graph
 
Reported: 2013-03-12 09:13 PDT by Jocelyn Turcotte
Modified: 2014-02-03 03:25 PST (History)
3 users (show)

See Also:

Attachments
Patch (3.01 KB, patch)
2013-03-12 09:18 PDT, Jocelyn Turcotte 		vestbo: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jocelyn Turcotte 2013-03-12 09:13:41 PDT 
[Qt][WK2] Remove the broken QWebDownloadItem lifetime management code
Comment 1 Jocelyn Turcotte 2013-03-12 09:18:09 PDT 
Created attachment 192750 [details]
Patch
Comment 2 Simon Hausmann 2013-03-13 14:20:38 PDT 
Comment on attachment 192750 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=192750&action=review

LGTM.

> Source/WebKit2/UIProcess/qt/QtDownloadManager.cpp:111
> +    // The objec's ownership is NOT transferable to the handler of this call, and deleting

objec += t :)
Comment 3 Tor Arne Vestbø 2013-03-14 09:46:41 PDT 
Comment on attachment 192750 [details]
Patch

lgtm, simons comment applied
Comment 4 Benjamin Poulain 2013-03-19 15:02:46 PDT 
Comment on attachment 192750 [details]
Patch

If leaking is fine for you, it is fine for me.
Signed off for WebKit2. Don't forget to fix this :)
Comment 5 Jocelyn Turcotte 2014-02-03 03:25:19 PST 
=== Bulk closing of Qt bugs ===

If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary.

If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines.