Bug 112171 - Moved RunLoopTimer and SchedulePair to WTF
Summary: Moved RunLoopTimer and SchedulePair to WTF
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-12 11:12 PDT by Geoffrey Garen
Modified: 2013-03-17 13:15 PDT (History)
8 users (show)

See Also:


Attachments
Patch (76.81 KB, patch)
2013-03-12 11:16 PDT, Geoffrey Garen
no flags Details | Formatted Diff | Diff
Patch (80.87 KB, patch)
2013-03-12 11:29 PDT, Geoffrey Garen
no flags Details | Formatted Diff | Diff
Patch (82.53 KB, patch)
2013-03-12 12:56 PDT, Geoffrey Garen
oliver: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2013-03-12 11:12:51 PDT
Moved RunLoopTimer and SchedulePair to WTF
Comment 1 Geoffrey Garen 2013-03-12 11:16:19 PDT
Created attachment 192773 [details]
Patch
Comment 2 WebKit Review Bot 2013-03-12 11:19:50 PDT
Attachment 192773 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/WTF.xcodeproj/project.pbxproj', u'Source/WTF/wtf/AutodrainedPool.h', u'Source/WTF/wtf/AutodrainedPoolMac.mm', u'Source/WTF/wtf/RunLoopTimer.h', u'Source/WTF/wtf/RunLoopTimerCF.cpp', u'Source/WTF/wtf/SchedulePair.cpp', u'Source/WTF/wtf/SchedulePair.h', u'Source/WTF/wtf/SchedulePairMac.mm', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/loader/DocumentLoader.h', u'Source/WebCore/loader/MainResourceLoader.h', u'Source/WebCore/page/Page.h', u'Source/WebCore/platform/AutodrainedPool.h', u'Source/WebCore/platform/cf/RunLoopTimerCF.cpp', u'Source/WebCore/platform/cf/SchedulePair.cpp', u'Source/WebCore/platform/cf/SchedulePair.h', u'Source/WebCore/platform/mac/AutodrainedPool.mm', u'Source/WebCore/platform/mac/SchedulePairMac.mm', u'Source/WebCore/platform/network/NetworkingContext.h', u'Source/WebCore/platform/network/ResourceHandle.h', u'Source/WebCore/platform/network/cf/FormDataStreamCFNet.cpp', u'Source/WebCore/platform/network/mac/ResourceHandleMac.mm', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/WebCoreSupport/WebFrameNetworkingContext.h', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.h']" exit_code: 1
Source/WTF/wtf/RunLoopTimer.h:32:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WTF/wtf/RunLoopTimerCF.cpp:33:  You should add a blank line after implementation file's own header.  [build/include_order] [4]
Total errors found: 2 in 22 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Early Warning System Bot 2013-03-12 11:24:35 PDT
Comment on attachment 192773 [details]
Patch

Attachment 192773 [details] did not pass qt-ews (qt):
Output: http://webkit-commit-queue.appspot.com/results/17196061
Comment 4 EFL EWS Bot 2013-03-12 11:26:38 PDT
Comment on attachment 192773 [details]
Patch

Attachment 192773 [details] did not pass efl-ews (efl):
Output: http://webkit-commit-queue.appspot.com/results/17174102
Comment 5 Geoffrey Garen 2013-03-12 11:29:24 PDT
Created attachment 192776 [details]
Patch
Comment 6 WebKit Review Bot 2013-03-12 11:31:36 PDT
Attachment 192776 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/WTF.xcodeproj/project.pbxproj', u'Source/WTF/wtf/AutodrainedPool.h', u'Source/WTF/wtf/AutodrainedPoolMac.mm', u'Source/WTF/wtf/RunLoopTimer.h', u'Source/WTF/wtf/RunLoopTimerCF.cpp', u'Source/WTF/wtf/SchedulePair.cpp', u'Source/WTF/wtf/SchedulePair.h', u'Source/WTF/wtf/SchedulePairMac.mm', u'Source/WebCore/ChangeLog', u'Source/WebCore/Modules/webdatabase/DatabaseThread.cpp', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/fileapi/FileThread.cpp', u'Source/WebCore/loader/DocumentLoader.h', u'Source/WebCore/loader/MainResourceLoader.h', u'Source/WebCore/loader/icon/IconDatabase.cpp', u'Source/WebCore/loader/icon/wince/IconDatabaseWinCE.cpp', u'Source/WebCore/page/Page.h', u'Source/WebCore/platform/AutodrainedPool.h', u'Source/WebCore/platform/cf/RunLoopCF.cpp', u'Source/WebCore/platform/cf/RunLoopTimerCF.cpp', u'Source/WebCore/platform/cf/SchedulePair.cpp', u'Source/WebCore/platform/cf/SchedulePair.h', u'Source/WebCore/platform/graphics/ca/mac/LayerFlushSchedulerMac.cpp', u'Source/WebCore/platform/mac/AutodrainedPool.mm', u'Source/WebCore/platform/mac/SchedulePairMac.mm', u'Source/WebCore/platform/network/NetworkingContext.h', u'Source/WebCore/platform/network/ResourceHandle.h', u'Source/WebCore/platform/network/cf/FormDataStreamCFNet.cpp', u'Source/WebCore/platform/network/cf/LoaderRunLoopCF.cpp', u'Source/WebCore/platform/network/mac/ResourceHandleMac.mm', u'Source/WebCore/storage/StorageThread.cpp', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/WebCoreSupport/WebFrameNetworkingContext.h', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.h']" exit_code: 1
Source/WTF/wtf/RunLoopTimer.h:32:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WTF/wtf/RunLoopTimerCF.cpp:33:  You should add a blank line after implementation file's own header.  [build/include_order] [4]
Total errors found: 2 in 30 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Mark Lam 2013-03-12 11:36:47 PDT
Comment on attachment 192776 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=192776&action=review

> Source/WTF/wtf/AutodrainedPool.h:2
> + * Copyright (C) 2007 Apple Inc. All rights reserved.

Drive by comment: update copyright headers?  Same for other moved files.
Comment 8 Geoffrey Garen 2013-03-12 12:56:46 PDT
Created attachment 192791 [details]
Patch
Comment 9 Geoffrey Garen 2013-03-12 12:57:30 PDT
Updated copyright in moved files.
Comment 10 WebKit Review Bot 2013-03-12 13:00:59 PDT
Attachment 192791 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/WTF.xcodeproj/project.pbxproj', u'Source/WTF/wtf/AutodrainedPool.h', u'Source/WTF/wtf/AutodrainedPoolMac.mm', u'Source/WTF/wtf/RunLoopTimer.h', u'Source/WTF/wtf/RunLoopTimerCF.cpp', u'Source/WTF/wtf/SchedulePair.cpp', u'Source/WTF/wtf/SchedulePair.h', u'Source/WTF/wtf/SchedulePairMac.mm', u'Source/WebCore/ChangeLog', u'Source/WebCore/Modules/webdatabase/DatabaseThread.cpp', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/fileapi/FileThread.cpp', u'Source/WebCore/loader/DocumentLoader.h', u'Source/WebCore/loader/MainResourceLoader.h', u'Source/WebCore/loader/icon/IconDatabase.cpp', u'Source/WebCore/loader/icon/wince/IconDatabaseWinCE.cpp', u'Source/WebCore/page/Page.h', u'Source/WebCore/platform/AutodrainedPool.h', u'Source/WebCore/platform/cf/RunLoopCF.cpp', u'Source/WebCore/platform/cf/RunLoopTimerCF.cpp', u'Source/WebCore/platform/cf/SchedulePair.cpp', u'Source/WebCore/platform/cf/SchedulePair.h', u'Source/WebCore/platform/graphics/ca/mac/LayerFlushSchedulerMac.cpp', u'Source/WebCore/platform/mac/AutodrainedPool.mm', u'Source/WebCore/platform/mac/SchedulePairMac.mm', u'Source/WebCore/platform/network/NetworkingContext.h', u'Source/WebCore/platform/network/ResourceHandle.h', u'Source/WebCore/platform/network/cf/FormDataStreamCFNet.cpp', u'Source/WebCore/platform/network/cf/LoaderRunLoopCF.cpp', u'Source/WebCore/platform/network/mac/ResourceHandleMac.mm', u'Source/WebCore/storage/StorageThread.cpp', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/WebCoreSupport/WebFrameNetworkingContext.h', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.h']" exit_code: 1
Source/WTF/wtf/RunLoopTimer.h:32:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WTF/wtf/RunLoopTimerCF.cpp:33:  You should add a blank line after implementation file's own header.  [build/include_order] [4]
Total errors found: 2 in 30 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 11 Oliver Hunt 2013-03-12 14:52:06 PDT
Comment on attachment 192791 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=192791&action=review

r=me, fix style issues before landing, and watch the windows bot

>> Source/WTF/wtf/RunLoopTimer.h:32
>> +#include <wtf/SchedulePair.h>
> 
> Alphabetical sorting problem.  [build/include_order] [4]

Please to be fixing this :D
Comment 12 Geoffrey Garen 2013-03-12 15:06:10 PDT
Committed r145592: <http://trac.webkit.org/changeset/145592>
Comment 13 David Kilzer (:ddkilzer) 2013-03-17 13:15:14 PDT
(In reply to comment #12)
> Committed r145592: <http://trac.webkit.org/changeset/145592>

Build fix:  http://trac.webkit.org/changeset/146023