Bug 114315 - ScriptExecutionContext log exception should include a column number
Summary: ScriptExecutionContext log exception should include a column number
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-04-09 16:02 PDT by Joseph Pecoraro
Modified: 2013-04-25 12:31 PDT (History)
5 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (35.21 KB, patch)
2013-04-24 20:20 PDT, Joseph Pecoraro 		oliver: review+
joepeck: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2013-04-09 16:02:22 PDT 
ScriptExecutionContext has logExceptionToConsole which may send error ConsoleMessages to the inspector. In order to jump to the proper place in source code the inspector needs both the line number and column number. Examples would be JavaScript runtime exceptions.
Comment 1 Radar WebKit Bug Importer 2013-04-09 16:03:27 PDT 
<rdar://problem/13614420>
Comment 2 Joseph Pecoraro 2013-04-09 16:04:54 PDT 
This should also cover ScriptExecutionContext::reportException.
Comment 3 Radar WebKit Bug Importer 2013-04-09 16:05:14 PDT 
<rdar://problem/13614454>
Comment 4 Joseph Pecoraro 2013-04-24 20:20:19 PDT 
Created attachment 199610 [details]
[PATCH] Proposed Fix

Likely requires a patch on another bug and needs to be rebased in order to build. I'll work on making that happen so the bots can build as expected. The change however would remain essentially the same.
Comment 5 Joseph Pecoraro 2013-04-25 12:31:11 PDT 
Landed r149131: <http://trac.webkit.org/changeset/149131>