Bug 114958 - WTF::AtomicString::find() should take unsigned 'start' argument
Summary: WTF::AtomicString::find() should take unsigned 'start' argument
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords:
Depends on:
Blocks: 107093
  Show dependency tree / graph
 
Reported: 2013-04-22 07:35 PDT by David Kilzer (:ddkilzer)
Modified: 2013-04-22 08:30 PDT (History)
4 users (show)

See Also:

Attachments
Patch v1 (2.80 KB, patch)
2013-04-22 07:39 PDT, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2013-04-22 07:35:46 PDT 
Fixes the following warnings with -Wshorten-64-to-32:

    AtomicString.h:113:76: error: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'unsigned int' [-Werror,-Wshorten-64-to-32]
        size_t find(UChar c, size_t start = 0) const { return m_string.find(c, start); }
                                                              ~~~~~~~~         ^~~~~
    AtomicString.h:115:35: error: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'unsigned int' [-Werror,-Wshorten-64-to-32]
            { return m_string.find(s, start, caseSentitive); }
                     ~~~~~~~~         ^~~~~
    AtomicString.h:117:35: error: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'unsigned int' [-Werror,-Wshorten-64-to-32]
            { return m_string.find(s, start, caseSentitive); }
                     ~~~~~~~~         ^~~~~
Comment 1 David Kilzer (:ddkilzer) 2013-04-22 07:39:10 PDT 
Created attachment 199027 [details]
Patch v1
Comment 2 David Kilzer (:ddkilzer) 2013-04-22 07:45:20 PDT 
> WTF::AtomicString::find() should take unsigned 'start' argument

Because WTF::String::find() takes an unsigned 'start' argument.
Comment 3 WebKit Commit Bot 2013-04-22 08:30:19 PDT 
Comment on attachment 199027 [details]
Patch v1

Clearing flags on attachment: 199027

Committed r148884: <http://trac.webkit.org/changeset/148884>
Comment 4 WebKit Commit Bot 2013-04-22 08:30:22 PDT 
All reviewed patches have been landed.  Closing bug.