Bug 115590 - Reoptimize free-standing :focus/link/visited/-webkit-any-link selectors.
Summary: Reoptimize free-standing :focus/link/visited/-webkit-any-link selectors.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords: Performance
Depends on:
Blocks:
 
Reported: 2013-05-04 09:52 PDT by Andreas Kling
Modified: 2013-05-09 13:35 PDT (History)
9 users (show)

See Also:

Attachments
Patch (3.27 KB, patch)
2013-05-04 09:53 PDT, Andreas Kling 		buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 (1.27 MB, application/zip)
2013-05-04 11:47 PDT, Build Bot 		no flags Details
how about this? (2.38 KB, patch)
2013-05-09 11:19 PDT, Antti Koivisto 		darin: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-05-04 09:52:45 PDT 
Reoptimize free-standing :focus/link/visited/-webkit-any-link selectors.
Comment 1 Andreas Kling 2013-05-04 09:53:20 PDT 
Created attachment 200532 [details]
Patch
Comment 2 Build Bot 2013-05-04 11:47:17 PDT 
Comment on attachment 200532 [details]
Patch

Attachment 200532 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/332820

New failing tests:
mathml/presentation/fractions.xhtml
mathml/presentation/mo.xhtml
mathml/presentation/mo-stretch.html
mathml/presentation/attributes.xhtml
mathml/presentation/row-alignment.xhtml
mathml/presentation/subsup.xhtml
mathml/presentation/fractions-vertical-alignment.xhtml
mathml/presentation/over.xhtml
fast/frames/crash-remove-iframe-during-object-beforeload.html
mathml/presentation/roots.xhtml
mathml/presentation/underover.xhtml
Comment 3 Build Bot 2013-05-04 11:47:18 PDT 
Created attachment 200535 [details]
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-11  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.2
Comment 4 Andreas Kling 2013-05-04 13:22:12 PDT 
Comment on attachment 200532 [details]
Patch

MathML why.
Comment 5 Antti Koivisto 2013-05-09 11:19:29 PDT 
Created attachment 201255 [details]
how about this?
Comment 6 Darin Adler 2013-05-09 11:21:17 PDT 
Comment on attachment 201255 [details]
how about this?

Is there some good way to regression-test this so people don’t break it again? I know it can be hard to regression-test performance changes.
Comment 7 Antti Koivisto 2013-05-09 11:26:32 PDT 
(In reply to comment #6)
> (From update of attachment 201255 [details])
> Is there some good way to regression-test this so people don’t break it again? I know it can be hard to regression-test performance changes.

I think this might even show up as progression in our regular tests. The change that broke this was a significant progression in itself and probably masked away the regression.

We could definitely use better testing for things like this. Maybe debug only Internal API to record exact optimisations used?
Comment 8 Antti Koivisto 2013-05-09 13:35:02 PDT 
http://trac.webkit.org/changeset/149838