Bug 115678 - KeyframeValueList::m_values should be Vector of OwnPtrs
Summary: KeyframeValueList::m_values should be Vector of OwnPtrs
Status: RESOLVED DUPLICATE of bug 115652
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks: 73757
  Show dependency tree / graph
 
Reported: 2013-05-06 14:33 PDT by Anders Carlsson
Modified: 2013-05-07 10:55 PDT (History)
10 users (show)

See Also:

Attachments
Patch (35.63 KB, patch)
2013-05-06 14:55 PDT, Anders Carlsson 		simon.fraser: review-
eflews.bot: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2013-05-06 14:33:18 PDT 
KeyframeValueList::m_values should be Vector of OwnPtrs
Comment 1 Anders Carlsson 2013-05-06 14:55:55 PDT 
Created attachment 200817 [details]
Patch
Comment 2 EFL EWS Bot 2013-05-06 15:00:17 PDT 
Comment on attachment 200817 [details]
Patch

Attachment 200817 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/378270
Comment 3 Early Warning System Bot 2013-05-06 15:01:30 PDT 
Comment on attachment 200817 [details]
Patch

Attachment 200817 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/281201
Comment 4 Simon Fraser (smfr) 2013-05-06 15:40:27 PDT 
Comment on attachment 200817 [details]
Patch

r-. Lots of red EWS and no justification.
Comment 5 Darin Adler 2013-05-07 09:13:04 PDT 
I fixed this in bug 115652, but Anders’ patch has some additional refactoring that still might be worthwhile beyond my fix.

*** This bug has been marked as a duplicate of bug 115652 ***
Comment 6 Anders Carlsson 2013-05-07 10:55:16 PDT 
(In reply to comment #5)
> I fixed this in bug 115652, but Anders’ patch has some additional refactoring that still might be worthwhile beyond my fix.
> 
> *** This bug has been marked as a duplicate of bug 115652 ***

Doing the additional refactoring in https://bugs.webkit.org/show_bug.cgi?id=115738.