Created attachment 201635 [details]
Patch v1

Comment on attachment 201635 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=201635&action=review

> Source/WebCore/ChangeLog:11
> +        (WebCore):

Normally better to remove lines like this when prepare-ChangeLog adds them.

> Source/WebCore/ChangeLog:16
> +        (WebCore):
> +        (ClipboardIOS):
> +        (WebCore::ClipboardIOS::create):

I don’t think we need to list the functions for added files. I usually delete them.

> Source/WebCore/ChangeLog:38
> +        (WebCore):
> +        (WebCore::Clipboard::create):
> +        (WebCore::ClipboardIOS::ClipboardIOS):
> +        (WebCore::ClipboardIOS::~ClipboardIOS):
> +        (WebCore::ClipboardIOS::hasData):
> +        (WebCore::utiTypeFromCocoaType):
> +        (WebCore::cocoaTypeFromHTMLClipboardType):
> +        (WebCore::addHTMLClipboardTypesForCocoaType):
> +        (WebCore::ClipboardIOS::clearData):
> +        (WebCore::ClipboardIOS::clearAllData):
> +        (WebCore::ClipboardIOS::getData):
> +        (WebCore::ClipboardIOS::setData):
> +        (WebCore::ClipboardIOS::types):
> +        (WebCore::ClipboardIOS::files):
> +        (WebCore::ClipboardIOS::writeRange):
> +        (WebCore::ClipboardIOS::writePlainText):
> +        (WebCore::ClipboardIOS::writeURL):
> +        (WebCore::ClipboardIOS::declareAndWriteDragImage):
> +        (WebCore::ClipboardIOS::createDragImage):
> +        (WebCore::ClipboardIOS::setDragImage):
> +        (WebCore::ClipboardIOS::setDragImageElement):

Ditto.

> Source/WebCore/ChangeLog:58
> +        (WebCore):
> +        (WebCore::Pasteboard::generalPasteboard):
> +        (WebCore::Pasteboard::Pasteboard):
> +        (WebCore::Pasteboard::clear):
> +        (WebCore::Pasteboard::getStringSelection):
> +        (WebCore::Pasteboard::writeSelection):
> +        (WebCore::Pasteboard::writePlainText):
> +        (WebCore::Pasteboard::writeImage):
> +        (WebCore::Pasteboard::writeClipboard):
> +        (WebCore::Pasteboard::canSmartReplace):
> +        (WebCore::Pasteboard::plainText):
> +        (WebCore::supportedImageTypes):
> +        (WebCore::Pasteboard::supportedPasteboardTypes):
> +        (WebCore::uniqueURLWithRelativePart):
> +        (WebCore::documentFragmentWithImageResource):
> +        (WebCore::documentFragmentWithLink):
> +        (WebCore::documentFragmentWithRTF):
> +        (WebCore::Pasteboard::documentFragmentForPasteboardItemAtIndex):
> +        (WebCore::Pasteboard::documentFragment):

Ditto.

Comment on attachment 201635 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=201635&action=review

>> Source/WebCore/ChangeLog:16
>> +        (WebCore::ClipboardIOS::create):
> 
> I don’t think we need to list the functions for added files. I usually delete them.

I actually find this very useful when I'm searching the ChangeLog (or commit log) by function name, but I will delete them.

Committed r150049: <http://trac.webkit.org/changeset/150049>

(In reply to comment #4)
> Committed r150049: <http://trac.webkit.org/changeset/150049>

Follow-up fix in r150054:  <http://trac.webkit.org/changeset/150054>

(In reply to comment #3)
> I actually find this very useful when I'm searching the ChangeLog (or commit log) by function name, but I will delete them.

Really? I also search change log by function name a *lot*, but do you really find it useful to see the check-in where an entire file was added? I haven’t noticed that I do.