Bug 116185 - Page::chrome() should return a reference.
Summary: Page::chrome() should return a reference.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-15 13:58 PDT by Andreas Kling
Modified: 2013-05-16 17:02 PDT (History)
4 users (show)

See Also:

Attachments
Patch (98.00 KB, patch)
2013-05-15 14:05 PDT, Andreas Kling 		webkit-ews: commit-queue-
Details | Formatted Diff | Diff
Patch v2 (107.30 KB, patch)
2013-05-15 14:15 PDT, Andreas Kling 		eflews.bot: commit-queue-
Details | Formatted Diff | Diff
Patch v3 (107.87 KB, patch)
2013-05-15 14:32 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-05-15 13:58:47 PDT 
Page::chrome() should return a reference.
Comment 1 Andreas Kling 2013-05-15 14:05:51 PDT 
Created attachment 201880 [details]
Patch
Comment 2 WebKit Commit Bot 2013-05-15 14:08:09 PDT 
Attachment 201880 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/Modules/webdatabase/DatabaseContext.cpp', u'Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm', u'Source/WebCore/bindings/js/JSDOMWindowBase.cpp', u'Source/WebCore/css/CSSDefaultStyleSheets.cpp', u'Source/WebCore/dom/ContainerNode.cpp', u'Source/WebCore/dom/Document.cpp', u'Source/WebCore/dom/Node.cpp', u'Source/WebCore/editing/EditorCommand.cpp', u'Source/WebCore/history/CachedFrame.cpp', u'Source/WebCore/html/BaseChooserOnlyDateAndTimeInputType.cpp', u'Source/WebCore/html/HTMLFormControlElementWithState.cpp', u'Source/WebCore/html/HTMLMediaElement.cpp', u'Source/WebCore/html/HTMLPlugInImageElement.cpp', u'Source/WebCore/html/HTMLVideoElement.cpp', u'Source/WebCore/html/InputType.cpp', u'Source/WebCore/html/shadow/MediaControls.cpp', u'Source/WebCore/html/shadow/SpinButtonElement.cpp', u'Source/WebCore/inspector/InspectorFrontendClientLocal.cpp', u'Source/WebCore/inspector/InspectorInputAgent.cpp', u'Source/WebCore/loader/FrameLoader.cpp', u'Source/WebCore/loader/FrameLoader.h', u'Source/WebCore/loader/SubframeLoader.cpp', u'Source/WebCore/loader/appcache/ApplicationCacheGroup.cpp', u'Source/WebCore/page/AutoscrollController.cpp', u'Source/WebCore/page/BarProp.cpp', u'Source/WebCore/page/Chrome.cpp', u'Source/WebCore/page/Console.cpp', u'Source/WebCore/page/ContextMenuController.cpp', u'Source/WebCore/page/DOMWindow.cpp', u'Source/WebCore/page/EventHandler.cpp', u'Source/WebCore/page/FocusController.cpp', u'Source/WebCore/page/Frame.cpp', u'Source/WebCore/page/FrameView.cpp', u'Source/WebCore/page/Page.h', u'Source/WebCore/page/PageConsole.cpp', u'Source/WebCore/page/PageGroup.cpp', u'Source/WebCore/page/mac/EventHandlerMac.mm', u'Source/WebCore/platform/mac/WidgetMac.mm', u'Source/WebCore/platform/network/FormData.cpp', u'Source/WebCore/rendering/InlineTextBox.cpp', u'Source/WebCore/rendering/RenderBox.cpp', u'Source/WebCore/rendering/RenderEmbeddedObject.cpp', u'Source/WebCore/rendering/RenderLayer.cpp', u'Source/WebCore/rendering/RenderLayerBacking.cpp', u'Source/WebCore/rendering/RenderLayerCompositor.cpp', u'Source/WebCore/rendering/RenderMenuList.cpp', u'Source/WebCore/rendering/RenderSearchField.cpp', u'Source/WebCore/rendering/RootInlineBox.cpp', u'Source/WebCore/rendering/svg/RenderSVGRoot.cpp', u'Source/WebCore/testing/Internals.cpp', u'Source/WebKit/blackberry/Api/WebPage.cpp', u'Source/WebKit/blackberry/ChangeLog', u'Source/WebKit/blackberry/WebCoreSupport/ColorPickerClient.cpp', u'Source/WebKit/blackberry/WebCoreSupport/DatePickerClient.cpp', u'Source/WebKit/blackberry/WebCoreSupport/SelectPopupClient.cpp', u'Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp', u'Source/WebKit/efl/ChangeLog', u'Source/WebKit/efl/WebCoreSupport/PopupMenuEfl.cpp', u'Source/WebKit/efl/ewk/ewk_view.cpp', u'Source/WebKit/gtk/ChangeLog', u'Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp', u'Source/WebKit/gtk/webkit/webkitviewportattributes.cpp', u'Source/WebKit/gtk/webkit/webkitwebview.cpp', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/WebView/WebFrame.mm', u'Source/WebKit/mac/WebView/WebHTMLView.mm', u'Source/WebKit/qt/ChangeLog', u'Source/WebKit/qt/WebCoreSupport/InitWebCoreQt.cpp', u'Source/WebKit/qt/WebCoreSupport/PlatformStrategiesQt.cpp', u'Source/WebKit/qt/WebCoreSupport/QWebFrameAdapter.cpp', u'Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.cpp', u'Source/WebKit/win/ChangeLog', u'Source/WebKit/win/WebView.cpp', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/WebProcess/Plugins/PDF/SimplePDFPlugin.mm', u'Source/WebKit2/WebProcess/Plugins/PluginView.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp', u'Source/WebKit2/WebProcess/WebPage/WebPage.cpp']" exit_code: 1
Source/WebCore/page/FrameView.cpp:593:  Should have a space between // and comment  [whitespace/comments] [4]
Total errors found: 1 in 79 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Early Warning System Bot 2013-05-15 14:12:18 PDT 
Comment on attachment 201880 [details]
Patch

Attachment 201880 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/481195
Comment 4 Early Warning System Bot 2013-05-15 14:13:55 PDT 
Comment on attachment 201880 [details]
Patch

Attachment 201880 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/471717
Comment 5 Andreas Kling 2013-05-15 14:15:23 PDT 
Created attachment 201881 [details]
Patch v2
Comment 6 EFL EWS Bot 2013-05-15 14:29:49 PDT 
Comment on attachment 201881 [details]
Patch v2

Attachment 201881 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/473666
Comment 7 Andreas Kling 2013-05-15 14:32:02 PDT 
Created attachment 201884 [details]
Patch v3
Comment 8 WebKit Commit Bot 2013-05-16 17:02:29 PDT 
Comment on attachment 201884 [details]
Patch v3

Clearing flags on attachment: 201884

Committed r150214: <http://trac.webkit.org/changeset/150214>
Comment 9 WebKit Commit Bot 2013-05-16 17:02:33 PDT 
All reviewed patches have been landed.  Closing bug.