Bug 116247 - filter-build-webkit: Don't filter out the location of the missing symbol when linking fails
Summary: filter-build-webkit: Don't filter out the location of the missing symbol when...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-16 14:35 PDT by David Kilzer (:ddkilzer)
Modified: 2013-05-17 12:33 PDT (History)
8 users (show)

See Also:

Attachments
Patch 1 of 3 (1.83 KB, patch)
2013-05-16 14:46 PDT, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
Patch 2 of 3 (29.00 KB, patch)
2013-05-16 14:47 PDT, David Kilzer (:ddkilzer) 		benjamin: review+
Details | Formatted Diff | Diff
Patch 3 of 3 (6.91 KB, patch)
2013-05-16 14:48 PDT, David Kilzer (:ddkilzer) 		benjamin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2013-05-16 14:35:10 PDT 
I keep seeing linker failures through filter-build-webkit that don't show the "blame" line due to the overzealous filtering.
Comment 1 David Kilzer (:ddkilzer) 2013-05-16 14:46:41 PDT 
Created attachment 201990 [details]
Patch 1 of 3
Comment 2 David Kilzer (:ddkilzer) 2013-05-16 14:47:29 PDT 
Created attachment 201991 [details]
Patch 2 of 3
Comment 3 David Kilzer (:ddkilzer) 2013-05-16 14:48:08 PDT 
Created attachment 201992 [details]
Patch 3 of 3
Comment 4 Benjamin Poulain 2013-05-16 15:38:14 PDT 
Comment on attachment 201991 [details]
Patch 2 of 3

I don't know anything about perl testing, gotta trust you on this one.
Comment 5 Benjamin Poulain 2013-05-16 15:41:55 PDT 
Comment on attachment 201992 [details]
Patch 3 of 3

View in context: https://bugs.webkit.org/attachment.cgi?id=201992&action=review

> Tools/Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:112
> +    my $lineLength = 200;

lineLength -> maxLineLength?
Comment 6 WebKit Commit Bot 2013-05-17 10:33:56 PDT 
Comment on attachment 201990 [details]
Patch 1 of 3

Clearing flags on attachment: 201990

Committed r150272: <http://trac.webkit.org/changeset/150272>
Comment 7 David Kilzer (:ddkilzer) 2013-05-17 12:33:52 PDT 
Part 2:  Committed r150285.  <http://trac.webkit.org/changeset/150285>
Part 3:  Committed r150286.  <http://trac.webkit.org/changeset/150286>