RESOLVED FIXED 116703
Typing in Safari's unified field causes unnecessary web content repaints.
https://bugs.webkit.org/show_bug.cgi?id=116703
Summary Typing in Safari's unified field causes unnecessary web content repaints.
Andreas Kling
Reported 2013-05-23 23:08:22 PDT
Typing in Safari's unified field causes unnecessary web content repaints.
Attachments
Patch (6.55 KB, patch)
2013-05-23 23:09 PDT, Andreas Kling
no flags
Andreas Kling
Comment 1 2013-05-23 23:09:30 PDT
Created attachment 202768 [details] Patch Give WebCore::Page the ability to count the number of times a string occurs in the page without painting anything.
Andy Estes
Comment 2 2013-05-23 23:36:40 PDT
Comment on attachment 202768 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=202768&action=review r=me. Looks like this is covered by the WebKit2.Find API test, so I assume this test still passes after this change. > Source/WebCore/page/Page.h:414 > + unsigned findMatchesForText(const String&, FindOptions, unsigned maxMatchCount, bool shouldHighlight, bool markMatches); You could use enums for shouldHighlight and markMatches for some added readability at call sites of this function.
WebKit Commit Bot
Comment 3 2013-05-24 00:11:58 PDT
Comment on attachment 202768 [details] Patch Clearing flags on attachment: 202768 Committed r150633: <http://trac.webkit.org/changeset/150633>
WebKit Commit Bot
Comment 4 2013-05-24 00:12:00 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.