Bug 116757 - Move "hover" state logic from Node to Element.
Summary: Move "hover" state logic from Node to Element.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-24 23:52 PDT by Andreas Kling
Modified: 2013-05-25 02:16 PDT (History)
8 users (show)

See Also:


Attachments
Patch (13.26 KB, patch)
2013-05-24 23:54 PDT, Andreas Kling
webkit-ews: commit-queue-
Details | Formatted Diff | Diff
Patch (14.70 KB, patch)
2013-05-25 00:27 PDT, Andreas Kling
koivisto: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-05-24 23:52:42 PDT
Move "hover" state logic from Node to Element.
Comment 1 Andreas Kling 2013-05-24 23:54:48 PDT
Created attachment 202876 [details]
Patch
Comment 2 Early Warning System Bot 2013-05-25 00:05:38 PDT
Comment on attachment 202876 [details]
Patch

Attachment 202876 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/652104
Comment 3 Early Warning System Bot 2013-05-25 00:06:50 PDT
Comment on attachment 202876 [details]
Patch

Attachment 202876 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/682176
Comment 4 EFL EWS Bot 2013-05-25 00:17:37 PDT
Comment on attachment 202876 [details]
Patch

Attachment 202876 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/684070
Comment 5 Build Bot 2013-05-25 00:24:52 PDT
Comment on attachment 202876 [details]
Patch

Attachment 202876 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/712089
Comment 6 Andreas Kling 2013-05-25 00:27:39 PDT
Created attachment 202877 [details]
Patch
Comment 7 Antti Koivisto 2013-05-25 01:42:17 PDT
Comment on attachment 202877 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=202877&action=review

r=me

> Source/WebCore/dom/ContainerNode.cpp:-1039
> -    // FIXME: Move to Element

wow, someone actually fixes FIXMEs!
Comment 8 Andreas Kling 2013-05-25 02:16:44 PDT
Committed r150684: <http://trac.webkit.org/changeset/150684>