Bug 116784 - Move Node::dispatchSimulatedClick() to Element.
Summary: Move Node::dispatchSimulatedClick() to Element.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-26 06:21 PDT by Andreas Kling
Modified: 2013-05-26 06:32 PDT (History)
4 users (show)

See Also:


Attachments
Patch (8.67 KB, patch)
2013-05-26 06:22 PDT, Andreas Kling
koivisto: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-05-26 06:21:09 PDT
Move Node::dispatchSimulatedClick() to Element.
Comment 1 Andreas Kling 2013-05-26 06:22:13 PDT
Created attachment 202917 [details]
Patch
Comment 2 Antti Koivisto 2013-05-26 06:25:32 PDT
Comment on attachment 202917 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=202917&action=review

> Source/WebCore/dom/EventDispatcher.cpp:85
> +    if (!gElementsDispatchingSimulatedClicks)
> +        gElementsDispatchingSimulatedClicks = new HashSet<Element*>;

How about switching to the appropriate WebKit pattern for this?
Comment 3 Andreas Kling 2013-05-26 06:32:54 PDT
Committed r150714: <http://trac.webkit.org/changeset/150714>