WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
116968
Take ComputedStyleExtractor for a spin.
https://bugs.webkit.org/show_bug.cgi?id=116968
Summary
Take ComputedStyleExtractor for a spin.
Andreas Kling
Reported
Wednesday, May 29, 2013 5:42:21 PM UTC
Take ComputedStyleExtractor for a spin.
Attachments
Patch
(11.53 KB, patch)
2013-05-29 09:42 PDT
,
Andreas Kling
webkit-ews
: commit-queue-
Details
Formatted Diff
Diff
Patch
(11.55 KB, patch)
2013-05-29 09:51 PDT
,
Andreas Kling
koivisto
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Andreas Kling
Comment 1
Wednesday, May 29, 2013 5:42:55 PM UTC
Created
attachment 203206
[details]
Patch
Early Warning System Bot
Comment 2
Wednesday, May 29, 2013 5:48:59 PM UTC
Comment on
attachment 203206
[details]
Patch
Attachment 203206
[details]
did not pass qt-ews (qt): Output:
http://webkit-queues.appspot.com/results/742188
Early Warning System Bot
Comment 3
Wednesday, May 29, 2013 5:51:07 PM UTC
Comment on
attachment 203206
[details]
Patch
Attachment 203206
[details]
did not pass qt-wk2-ews (qt-wk2): Output:
http://webkit-queues.appspot.com/results/750227
Andreas Kling
Comment 4
Wednesday, May 29, 2013 5:51:45 PM UTC
Created
attachment 203208
[details]
Patch
Antti Koivisto
Comment 5
Wednesday, May 29, 2013 7:22:46 PM UTC
Comment on
attachment 203208
[details]
Patch r=me
Antti Koivisto
Comment 6
Wednesday, May 29, 2013 7:30:14 PM UTC
Comment on
attachment 203208
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=203208&action=review
> Source/WebCore/editing/ApplyStyleCommand.cpp:459 > + int unicodeBidi = getIdentifierValue(ComputedStyleExtractor(n), CSSPropertyUnicodeBidi);
Why does getIdentifierValue take ComputedStyleExtractor instead of a node? Seems unnecessarily abstract.
Andreas Kling
Comment 7
Thursday, May 30, 2013 5:11:39 AM UTC
Committed
r150945
: <
http://trac.webkit.org/changeset/150945
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug