Bug 116968 - Take ComputedStyleExtractor for a spin.
Summary: Take ComputedStyleExtractor for a spin.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords: Performance
Depends on:
Blocks:
 
Reported: 2013-05-29 09:42 PDT by Andreas Kling
Modified: 2013-05-29 21:11 PDT (History)
2 users (show)

See Also:

Attachments
Patch (11.53 KB, patch)
2013-05-29 09:42 PDT, Andreas Kling 		webkit-ews: commit-queue-
Details | Formatted Diff | Diff
Patch (11.55 KB, patch)
2013-05-29 09:51 PDT, Andreas Kling 		koivisto: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-05-29 09:42:21 PDT 
Take ComputedStyleExtractor for a spin.
Comment 1 Andreas Kling 2013-05-29 09:42:55 PDT 
Created attachment 203206 [details]
Patch
Comment 2 Early Warning System Bot 2013-05-29 09:48:59 PDT 
Comment on attachment 203206 [details]
Patch

Attachment 203206 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/742188
Comment 3 Early Warning System Bot 2013-05-29 09:51:07 PDT 
Comment on attachment 203206 [details]
Patch

Attachment 203206 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/750227
Comment 4 Andreas Kling 2013-05-29 09:51:45 PDT 
Created attachment 203208 [details]
Patch
Comment 5 Antti Koivisto 2013-05-29 11:22:46 PDT 
Comment on attachment 203208 [details]
Patch

r=me
Comment 6 Antti Koivisto 2013-05-29 11:30:14 PDT 
Comment on attachment 203208 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=203208&action=review

> Source/WebCore/editing/ApplyStyleCommand.cpp:459
> +        int unicodeBidi = getIdentifierValue(ComputedStyleExtractor(n), CSSPropertyUnicodeBidi);

Why does getIdentifierValue take ComputedStyleExtractor instead of a node? Seems unnecessarily abstract.
Comment 7 Andreas Kling 2013-05-29 21:11:39 PDT 
Committed r150945: <http://trac.webkit.org/changeset/150945>