Bug 117019 - Avoid using CSSOM style declarations in HTML editing.
Summary: Avoid using CSSOM style declarations in HTML editing.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords: Performance
Depends on:
Blocks:
 
Reported: 2013-05-30 00:50 PDT by Andreas Kling
Modified: 2013-05-30 05:53 PDT (History)
7 users (show)

See Also:

Attachments
Snack for EWS (37.19 KB, patch)
2013-05-30 00:51 PDT, Andreas Kling 		webkit-ews: commit-queue-
Details | Formatted Diff | Diff
Dessert for EWS (38.48 KB, patch)
2013-05-30 00:57 PDT, Andreas Kling 		webkit-ews: commit-queue-
Details | Formatted Diff | Diff
Salad for EWS (37.51 KB, patch)
2013-05-30 01:36 PDT, Andreas Kling 		buildbot: commit-queue-
Details | Formatted Diff | Diff
Pretentious patch (38.52 KB, patch)
2013-05-30 02:58 PDT, Andreas Kling 		koivisto: review+
Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-05-30 00:50:27 PDT 
We should use ComputedStyleExtractor instead.
Comment 1 Andreas Kling 2013-05-30 00:51:00 PDT 
Created attachment 203318 [details]
Snack for EWS
Comment 2 Early Warning System Bot 2013-05-30 00:56:57 PDT 
Comment on attachment 203318 [details]
Snack for EWS

Attachment 203318 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/692349
Comment 3 Andreas Kling 2013-05-30 00:57:12 PDT 
Created attachment 203320 [details]
Dessert for EWS
Comment 4 Early Warning System Bot 2013-05-30 01:04:17 PDT 
Comment on attachment 203320 [details]
Dessert for EWS

Attachment 203320 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/675672
Comment 5 Early Warning System Bot 2013-05-30 01:04:28 PDT 
Comment on attachment 203320 [details]
Dessert for EWS

Attachment 203320 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/751283
Comment 6 Build Bot 2013-05-30 01:28:18 PDT 
Comment on attachment 203320 [details]
Dessert for EWS

Attachment 203320 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/726204
Comment 7 Andreas Kling 2013-05-30 01:36:07 PDT 
Created attachment 203323 [details]
Salad for EWS
Comment 8 Build Bot 2013-05-30 01:51:18 PDT 
Comment on attachment 203323 [details]
Salad for EWS

Attachment 203323 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/742354
Comment 9 Build Bot 2013-05-30 01:54:29 PDT 
Comment on attachment 203323 [details]
Salad for EWS

Attachment 203323 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/665605
Comment 10 kov's GTK+ EWS bot 2013-05-30 01:54:56 PDT 
Comment on attachment 203323 [details]
Salad for EWS

Attachment 203323 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/683538
Comment 11 Andreas Kling 2013-05-30 02:58:10 PDT 
Created attachment 203330 [details]
Pretentious patch
Comment 12 Antti Koivisto 2013-05-30 03:31:32 PDT 
Comment on attachment 203330 [details]
Pretentious patch

View in context: https://bugs.webkit.org/attachment.cgi?id=203330&action=review

> Source/WebCore/ChangeLog:60
> +        (WebCore::getPropertyValue):
> +        (WebCore::getIdentifierValue):
> +        (WebCore::getRGBAFontColor):
> +        (WebCore::getRGBABackgroundColor):

Would be nice to use webkit naming style here (get* is only used for functions that return value in argument).

> Source/WebCore/ChangeLog:70
> +        (WebCore::getPropertiesNotIn):

Here too.
Comment 13 Andreas Kling 2013-05-30 05:53:18 PDT 
Committed r150960: <http://trac.webkit.org/changeset/150960>