Bug 118952 - KURL creates duplicate strings when completing data: URIs.
Summary: KURL creates duplicate strings when completing data: URIs.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords: InRadar, Performance
Depends on:
Blocks:
 
Reported: 2013-07-21 09:02 PDT by Andreas Kling
Modified: 2013-07-23 12:29 PDT (History)
4 users (show)

See Also:


Attachments
Patch (2.77 KB, patch)
2013-07-21 09:05 PDT, Andreas Kling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-07-21 09:02:52 PDT
KURL creates duplicate strings when completing data: URIs.
Comment 1 Radar WebKit Bug Importer 2013-07-21 09:03:05 PDT
<rdar://problem/14504480>
Comment 2 Andreas Kling 2013-07-21 09:05:48 PDT
Created attachment 207209 [details]
Patch
Comment 3 WebKit Commit Bot 2013-07-21 12:04:42 PDT
Comment on attachment 207209 [details]
Patch

Clearing flags on attachment: 207209

Committed r152951: <http://trac.webkit.org/changeset/152951>
Comment 4 WebKit Commit Bot 2013-07-21 12:04:44 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Roger Fong 2013-07-23 11:56:13 PDT
I think that this may have caused 4 tests to start failing.
In particular,
http://build-safari.apple.com/results/Cab%20Debug%20Tests/r153057_53185%20(21903)/results.html

My guess is just based on looking at regression ranges.
There also is a test or two in that set of 4 that involves URL's.

Can you take a look? Thanks
Comment 6 Andreas Kling 2013-07-23 12:18:59 PDT
(In reply to comment #5)
> I think that this may have caused 4 tests to start failing.
> In particular,
> http://build-safari.apple.com/results/Cab%20Debug%20Tests/r153057_53185%20(21903)/results.html
> 
> My guess is just based on looking at regression ranges.
> There also is a test or two in that set of 4 that involves URL's.
> 
> Can you take a look? Thanks

I can repro the failures locally, even with that change reverted :/
Comment 7 Roger Fong 2013-07-23 12:29:20 PDT
(In reply to comment #6)
> (In reply to comment #5)
> > I think that this may have caused 4 tests to start failing.
> > In particular,
> > http://build-safari.apple.com/results/Cab%20Debug%20Tests/r153057_53185%20(21903)/results.html
> > 
> > My guess is just based on looking at regression ranges.
> > There also is a test or two in that set of 4 that involves URL's.
> > 
> > Can you take a look? Thanks
> 
> I can repro the failures locally, even with that change reverted :/

Humm, nvm then,  maybe its one of phil's jsc changes which were also in that area. I'll try reverting dsome of those.
thx!