Bug 119046 - RenderMenuList computes the width of its longest option twice.
Summary: RenderMenuList computes the width of its longest option twice.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords: InRadar, Performance
Depends on:
Blocks:
 
Reported: 2013-07-24 10:01 PDT by Andreas Kling
Modified: 2013-07-24 12:10 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.31 KB, patch)
2013-07-24 10:05 PDT, Andreas Kling 		darin: review+
Details | Formatted Diff | Diff
Moon lander (2.71 KB, patch)
2013-07-24 10:33 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-07-24 10:01:34 PDT 
RenderMenuList computes the width of its longest option twice.
Comment 1 Radar WebKit Bug Importer 2013-07-24 10:02:27 PDT 
<rdar://problem/14534679>
Comment 2 Andreas Kling 2013-07-24 10:05:10 PDT 
Created attachment 207402 [details]
Patch
Comment 3 Darin Adler 2013-07-24 10:16:09 PDT 
Comment on attachment 207402 [details]
Patch

The name m_optionsChanged seems poor. Changed since when? The name should mention width.
Comment 4 Andreas Kling 2013-07-24 10:33:05 PDT 
Created attachment 207403 [details]
Moon lander
Comment 5 WebKit Commit Bot 2013-07-24 12:10:30 PDT 
Comment on attachment 207403 [details]
Moon lander

Clearing flags on attachment: 207403

Committed r153094: <http://trac.webkit.org/changeset/153094>
Comment 6 WebKit Commit Bot 2013-07-24 12:10:33 PDT 
All reviewed patches have been landed.  Closing bug.