Bug 119662 - Make Page::settings() return a reference.
Summary: Make Page::settings() return a reference.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-11 09:43 PDT by Andreas Kling
Modified: 2013-08-11 13:29 PDT (History)
10 users (show)

See Also:


Attachments
Patch (136.39 KB, patch)
2013-08-11 09:44 PDT, Andreas Kling
webkit-ews: commit-queue-
Details | Formatted Diff | Diff
Patch! Part Deux (161.74 KB, patch)
2013-08-11 10:17 PDT, Andreas Kling
webkit-ews: commit-queue-
Details | Formatted Diff | Diff
Patch III: #awyiss (163.11 KB, patch)
2013-08-11 10:30 PDT, Andreas Kling
eflews.bot: commit-queue-
Details | Formatted Diff | Diff
Patch IV: Bueller? (165.37 KB, patch)
2013-08-11 10:46 PDT, Andreas Kling
gtk-ews: commit-queue-
Details | Formatted Diff | Diff
Patch V: Is this on? (192.36 KB, patch)
2013-08-11 11:01 PDT, Andreas Kling
andersca: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (192.36 KB, patch)
2013-08-11 11:38 PDT, Andreas Kling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-08-11 09:43:54 PDT
Make Page::settings() return a reference.
Comment 1 Andreas Kling 2013-08-11 09:44:41 PDT
Created attachment 208496 [details]
Patch
Comment 2 WebKit Commit Bot 2013-08-11 09:47:44 PDT
Attachment 208496 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/Modules/webdatabase/DatabaseContext.cpp', u'Source/WebCore/css/StyleResolver.cpp', u'Source/WebCore/dom/Document.cpp', u'Source/WebCore/history/CachedPage.cpp', u'Source/WebCore/history/PageCache.cpp', u'Source/WebCore/html/HTMLFormElement.cpp', u'Source/WebCore/html/HTMLLinkElement.cpp', u'Source/WebCore/html/HTMLMediaElement.cpp', u'Source/WebCore/html/HTMLObjectElement.cpp', u'Source/WebCore/html/HTMLPlugInImageElement.cpp', u'Source/WebCore/html/ImageDocument.cpp', u'Source/WebCore/html/ValidationMessage.cpp', u'Source/WebCore/html/canvas/WebGLRenderingContext.cpp', u'Source/WebCore/html/shadow/MediaControls.cpp', u'Source/WebCore/inspector/InspectorAgent.cpp', u'Source/WebCore/inspector/InspectorFrontendClientLocal.cpp', u'Source/WebCore/inspector/InspectorOverlay.cpp', u'Source/WebCore/inspector/InspectorPageAgent.cpp', u'Source/WebCore/loader/SubframeLoader.cpp', u'Source/WebCore/loader/archive/cf/LegacyWebArchive.cpp', u'Source/WebCore/loader/icon/IconController.cpp', u'Source/WebCore/page/CaptionUserPreferences.cpp', u'Source/WebCore/page/Chrome.cpp', u'Source/WebCore/page/Console.cpp', u'Source/WebCore/page/ContextMenuController.cpp', u'Source/WebCore/page/DOMWindow.cpp', u'Source/WebCore/page/EventHandler.cpp', u'Source/WebCore/page/Frame.cpp', u'Source/WebCore/page/FrameView.cpp', u'Source/WebCore/page/Navigator.cpp', u'Source/WebCore/page/Page.h', u'Source/WebCore/page/PageConsole.cpp', u'Source/WebCore/page/Settings.cpp', u'Source/WebCore/page/make_settings.pl', u'Source/WebCore/platform/blackberry/PlatformScreenBlackBerry.cpp', u'Source/WebCore/platform/graphics/texmap/coordinated/CompositingCoordinator.cpp', u'Source/WebCore/platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp', u'Source/WebCore/plugins/PluginView.cpp', u'Source/WebCore/rendering/RenderLayer.cpp', u'Source/WebCore/rendering/svg/RenderSVGResourceFilter.cpp', u'Source/WebCore/storage/Storage.cpp', u'Source/WebCore/storage/StorageNamespaceImpl.cpp', u'Source/WebCore/svg/graphics/SVGImage.cpp', u'Source/WebCore/testing/InternalSettings.cpp', u'Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp', u'Source/WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp', u'Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp', u'Source/WebKit/mac/WebCoreSupport/WebEditorClient.mm', u'Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm', u'Source/WebKit/mac/WebView/WebView.mm', u'Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp', u'Source/WebKit/qt/WebCoreSupport/EditorClientQt.cpp', u'Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.cpp', u'Source/WebKit/win/WebCoreSupport/WebEditorClient.cpp', u'Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp', u'Source/WebKit/win/WebView.cpp', u'Source/WebKit/wince/WebCoreSupport/EditorClientWinCE.cpp', u'Source/WebKit2/WebProcess/WebPage/WebPage.cpp', u'Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm']" exit_code: 1
Source/WebCore/html/ImageDocument.cpp:377:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Total errors found: 1 in 60 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Early Warning System Bot 2013-08-11 09:51:36 PDT
Comment on attachment 208496 [details]
Patch

Attachment 208496 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1405800
Comment 4 Early Warning System Bot 2013-08-11 09:51:42 PDT
Comment on attachment 208496 [details]
Patch

Attachment 208496 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1410800
Comment 5 EFL EWS Bot 2013-08-11 09:59:09 PDT
Comment on attachment 208496 [details]
Patch

Attachment 208496 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/1399817
Comment 6 EFL EWS Bot 2013-08-11 10:11:46 PDT
Comment on attachment 208496 [details]
Patch

Attachment 208496 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/1413809
Comment 7 Build Bot 2013-08-11 10:17:12 PDT
Comment on attachment 208496 [details]
Patch

Attachment 208496 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1409903
Comment 8 Andreas Kling 2013-08-11 10:17:53 PDT
Created attachment 208497 [details]
Patch! Part Deux
Comment 9 Early Warning System Bot 2013-08-11 10:26:01 PDT
Comment on attachment 208497 [details]
Patch! Part Deux

Attachment 208497 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1409907
Comment 10 Early Warning System Bot 2013-08-11 10:27:39 PDT
Comment on attachment 208497 [details]
Patch! Part Deux

Attachment 208497 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1399825
Comment 11 Andreas Kling 2013-08-11 10:30:05 PDT
Created attachment 208499 [details]
Patch III: #awyiss
Comment 12 EFL EWS Bot 2013-08-11 10:45:39 PDT
Comment on attachment 208499 [details]
Patch III: #awyiss

Attachment 208499 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/1444099
Comment 13 Andreas Kling 2013-08-11 10:46:03 PDT
Created attachment 208500 [details]
Patch IV: Bueller?
Comment 14 kov's GTK+ EWS bot 2013-08-11 10:56:52 PDT
Comment on attachment 208500 [details]
Patch IV: Bueller?

Attachment 208500 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/1412792
Comment 15 Andreas Kling 2013-08-11 11:01:17 PDT
Created attachment 208501 [details]
Patch V: Is this on?
Comment 16 WebKit Commit Bot 2013-08-11 11:33:36 PDT
Comment on attachment 208501 [details]
Patch V: Is this on?

Rejecting attachment 208501 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 208501, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.appspot.com/results/1410825
Comment 17 Andreas Kling 2013-08-11 11:38:41 PDT
Created attachment 208502 [details]
Patch for landing
Comment 18 Andreas Kling 2013-08-11 13:29:44 PDT
Comment on attachment 208502 [details]
Patch for landing

Clearing flags on attachment: 208502

Committed r153927: <http://trac.webkit.org/changeset/153927>
Comment 19 Andreas Kling 2013-08-11 13:29:51 PDT
All reviewed patches have been landed.  Closing bug.