119677 – Page::mainFrame() should return a reference.

Bug 119677 - Page::mainFrame() should return a reference.

Summary: Page::mainFrame() should return a reference.

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	WebCore Misc. (show other bugs)
Version:	528+ (Nightly build)
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Andreas Kling

URL:
Keywords:

Depends on:
Blocks:

Reported:	2013-08-12 03:50 PDT by Andreas Kling
Modified:	2013-08-26 20:38 PDT (History)
CC List:	37 users (show)

See Also:

Attachments
For EWS to make fun of (42.22 KB, patch) 2013-08-12 03:52 PDT, Andreas Kling	no flags	Details \| Formatted Diff \| Diff
For EWS to make fun of (230.07 KB, patch) 2013-08-12 03:53 PDT, Andreas Kling	webkit-ews: commit-queue-	Details \| Formatted Diff \| Diff
EWS mockery round 2 (233.98 KB, patch) 2013-08-12 04:09 PDT, Andreas Kling	no flags	Details \| Formatted Diff \| Diff
EWS mockery round 2 (234.51 KB, patch) 2013-08-12 04:10 PDT, Andreas Kling	webkit-ews: commit-queue-	Details \| Formatted Diff \| Diff
EWS funtime party 3 (239.27 KB, patch) 2013-08-12 04:35 PDT, Andreas Kling	no flags	Details \| Formatted Diff \| Diff
Patch (240.08 KB, patch) 2013-08-12 04:59 PDT, Andreas Kling	koivisto: review+ gtk-ews: commit-queue-	Details \| Formatted Diff \| Diff
Patch for landing (if EWS likes) (221.91 KB, patch) 2013-08-26 18:06 PDT, Andreas Kling	webkit-ews: commit-queue-	Details \| Formatted Diff \| Diff
Patch for landing (come on, EWS, let's be friends) (230.60 KB, patch) 2013-08-26 18:25 PDT, Andreas Kling	webkit-ews: commit-queue-	Details \| Formatted Diff \| Diff
Patch for landing (ews pls) (230.94 KB, patch) 2013-08-26 18:38 PDT, Andreas Kling	webkit-ews: commit-queue-	Details \| Formatted Diff \| Diff
Patch for landing (totally...) (233.56 KB, patch) 2013-08-26 18:48 PDT, Andreas Kling	webkit-ews: commit-queue-	Details \| Formatted Diff \| Diff
Patch for landing (!) (235.50 KB, patch) 2013-08-26 19:21 PDT, Andreas Kling	no flags	Details \| Formatted Diff \| Diff
Show Obsolete (10) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Andreas Kling 2013-08-12 03:50:16 PDT

In practice, WebCore::Page always has a mainFrame(). There's a small window between Page construction and setMainFrame() where Page::m_mainFrame is null, but mainFrame() should never be called in that time.
We should make the method return a reference and remove that window, or at least guard it with an assertion.

Comment 1 Andreas Kling 2013-08-12 03:52:38 PDT

Created attachment 208526 [details]
For EWS to make fun of

Comment 2 Andreas Kling 2013-08-12 03:53:16 PDT

Created attachment 208527 [details]
For EWS to make fun of

Comment 3 WebKit Commit Bot 2013-08-12 03:55:24 PDT

Attachment 208527 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/bindings/js/PageScriptDebugServer.cpp', u'Source/WebCore/bindings/js/ScriptCachedFrameData.cpp', u'Source/WebCore/bindings/js/ScriptCachedFrameData.h', u'Source/WebCore/bindings/js/ScriptProfiler.cpp', u'Source/WebCore/bindings/js/ScriptState.cpp', u'Source/WebCore/css/MediaQueryEvaluator.cpp', u'Source/WebCore/dom/Document.cpp', u'Source/WebCore/history/CachedFrame.cpp', u'Source/WebCore/history/CachedFrame.h', u'Source/WebCore/history/CachedPage.cpp', u'Source/WebCore/history/PageCache.cpp', u'Source/WebCore/html/HTMLPlugInImageElement.cpp', u'Source/WebCore/html/ImageDocument.cpp', u'Source/WebCore/inspector/InspectorAgent.cpp', u'Source/WebCore/inspector/InspectorApplicationCacheAgent.cpp', u'Source/WebCore/inspector/InspectorCanvasAgent.cpp', u'Source/WebCore/inspector/InspectorClient.cpp', u'Source/WebCore/inspector/InspectorController.cpp', u'Source/WebCore/inspector/InspectorDOMAgent.cpp', u'Source/WebCore/inspector/InspectorDebuggerAgent.cpp', u'Source/WebCore/inspector/InspectorFrontendClientLocal.cpp', u'Source/WebCore/inspector/InspectorFrontendHost.cpp', u'Source/WebCore/inspector/InspectorInputAgent.cpp', u'Source/WebCore/inspector/InspectorInstrumentation.cpp', u'Source/WebCore/inspector/InspectorOverlay.cpp', u'Source/WebCore/inspector/InspectorPageAgent.cpp', u'Source/WebCore/inspector/InspectorPageAgent.h', u'Source/WebCore/inspector/InspectorResourceAgent.cpp', u'Source/WebCore/inspector/InspectorTimelineAgent.cpp', u'Source/WebCore/inspector/PageDebuggerAgent.cpp', u'Source/WebCore/inspector/PageRuntimeAgent.cpp', u'Source/WebCore/loader/FrameLoader.cpp', u'Source/WebCore/loader/HistoryController.cpp', u'Source/WebCore/loader/archive/mhtml/MHTMLArchive.cpp', u'Source/WebCore/page/Chrome.cpp', u'Source/WebCore/page/ContextMenuController.cpp', u'Source/WebCore/page/ContextMenuController.h', u'Source/WebCore/page/DOMWindow.cpp', u'Source/WebCore/page/DragController.cpp', u'Source/WebCore/page/EventHandler.cpp', u'Source/WebCore/page/FocusController.cpp', u'Source/WebCore/page/Frame.cpp', u'Source/WebCore/page/FrameTree.cpp', u'Source/WebCore/page/FrameView.cpp', u'Source/WebCore/page/Page.cpp', u'Source/WebCore/page/Page.h', u'Source/WebCore/page/PageGroup.cpp', u'Source/WebCore/page/PageGroupLoadDeferrer.cpp', u'Source/WebCore/page/PageSerializer.cpp', u'Source/WebCore/page/PageThrottler.cpp', u'Source/WebCore/page/Settings.cpp', u'Source/WebCore/page/SpatialNavigation.cpp', u'Source/WebCore/page/mac/DragControllerMac.mm', u'Source/WebCore/page/scrolling/ScrollingCoordinator.cpp', u'Source/WebCore/page/scrolling/blackberry/ScrollingCoordinatorBlackBerry.cpp', u'Source/WebCore/page/scrolling/mac/ScrollingCoordinatorMac.mm', u'Source/WebCore/platform/graphics/texmap/coordinated/CompositingCoordinator.cpp', u'Source/WebCore/platform/network/blackberry/SocketStreamHandleBlackBerry.cpp', u'Source/WebCore/plugins/DOMMimeType.cpp', u'Source/WebCore/rendering/RenderBox.cpp', u'Source/WebCore/rendering/RenderLayerBacking.cpp', u'Source/WebCore/storage/StorageEventDispatcher.cpp', u'Source/WebCore/svg/graphics/SVGImage.cpp', u'Source/WebCore/testing/InternalSettings.cpp', u'Source/WebCore/testing/Internals.cpp', u'Source/WebKit/efl/WebCoreSupport/AcceleratedCompositingContextEfl.cpp', u'Source/WebKit/efl/WebCoreSupport/InspectorClientEfl.cpp', u'Source/WebKit/gtk/WebCoreSupport/AcceleratedCompositingContextGL.cpp', u'Source/WebKit/gtk/WebCoreSupport/GtkAdjustmentWatcher.cpp', u'Source/WebKit/gtk/webkit/webkitviewportattributes.cpp', u'Source/WebKit/gtk/webkit/webkitwebview.cpp', u'Source/WebKit/mac/WebCoreSupport/WebDragClient.mm', u'Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm', u'Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm', u'Source/WebKit/mac/WebCoreSupport/WebPlatformStrategies.mm', u'Source/WebKit/mac/WebView/WebFrameView.mm', u'Source/WebKit/mac/WebView/WebHTMLView.mm', u'Source/WebKit/mac/WebView/WebView.mm', u'Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp', u'Source/WebKit/qt/WebCoreSupport/NotificationPresenterClientQt.cpp', u'Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.cpp', u'Source/WebKit/win/WebCoreSupport/WebContextMenuClient.cpp', u'Source/WebKit/win/WebCoreSupport/WebDragClient.cpp', u'Source/WebKit/win/WebDropSource.cpp', u'Source/WebKit/win/WebView.cpp', u'Source/WebKit/wince/WebView.cpp', u'Source/WebKit2/WebProcess/FullScreen/WebFullScreenManager.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp', u'Source/WebKit2/WebProcess/Plugins/PluginView.cpp', u'Source/WebKit2/WebProcess/Storage/StorageAreaMap.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebContextMenuClient.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm', u'Source/WebKit2/WebProcess/WebPage/FindController.cpp', u'Source/WebKit2/WebProcess/WebPage/PageOverlay.cpp', u'Source/WebKit2/WebProcess/WebPage/WebInspector.cpp', u'Source/WebKit2/WebProcess/WebPage/WebPage.cpp', u'Source/WebKit2/WebProcess/WebPage/WebPage.h', u'Source/WebKit2/WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp', u'Source/WebKit2/WebProcess/WebPage/mac/LayerTreeHostMac.mm', u'Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeContext.mm', u'Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm', u'Source/WebKit2/WebProcess/WebPage/mac/WKAccessibilityWebPageObject.mm', u'Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm']" exit_code: 1
Source/WebKit/win/WebCoreSupport/WebDragClient.cpp:93:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 107 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 4 Early Warning System Bot 2013-08-12 04:02:19 PDT

Comment on attachment 208527 [details]
For EWS to make fun of

Attachment 208527 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1447226

Comment 5 EFL EWS Bot 2013-08-12 04:03:45 PDT

Comment on attachment 208527 [details]
For EWS to make fun of

Attachment 208527 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/1451069

Comment 6 Andreas Kling 2013-08-12 04:09:33 PDT

Created attachment 208530 [details]
EWS mockery round 2

Comment 7 Andreas Kling 2013-08-12 04:10:39 PDT

Created attachment 208531 [details]
EWS mockery round 2

Comment 8 Early Warning System Bot 2013-08-12 04:35:04 PDT

Comment on attachment 208531 [details]
EWS mockery round 2

Attachment 208531 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1451074

Comment 9 Andreas Kling 2013-08-12 04:35:59 PDT

Created attachment 208533 [details]
EWS funtime party 3

Comment 10 Andreas Kling 2013-08-12 04:59:29 PDT

Created attachment 208535 [details]
Patch

Comment 11 Antti Koivisto 2013-08-12 05:02:29 PDT

Comment on attachment 208535 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=208535&action=review

rs=me

> Source/WebCore/ChangeLog:11
> +        In practice, Page always has a mainFrame(). There's a short window in time
> +        between construction and Frame::create() calling Page::setMainFrame() where
> +        m_page is null, but mainFrame() should not be used then. We guard against
> +        this with an assertion in mainFrame().

Would be nice to cleanup this awkward construction pattern.

Comment 12 kov's GTK+ EWS bot 2013-08-12 05:30:31 PDT

Comment on attachment 208535 [details]
Patch

Attachment 208535 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/1456041

Comment 13 Andreas Kling 2013-08-26 18:06:27 PDT

Created attachment 209699 [details]
Patch for landing (if EWS likes)

Finally updated this now that Page creates the mainFrame().

Comment 14 WebKit Commit Bot 2013-08-26 18:10:24 PDT

Attachment 209699 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm', u'Source/WebCore/bindings/js/PageScriptDebugServer.cpp', u'Source/WebCore/bindings/js/ScriptProfiler.cpp', u'Source/WebCore/bindings/js/ScriptState.cpp', u'Source/WebCore/css/MediaQueryEvaluator.cpp', u'Source/WebCore/dom/Document.cpp', u'Source/WebCore/history/CachedFrame.cpp', u'Source/WebCore/history/CachedPage.cpp', u'Source/WebCore/history/PageCache.cpp', u'Source/WebCore/html/HTMLPlugInImageElement.cpp', u'Source/WebCore/html/ImageDocument.cpp', u'Source/WebCore/inspector/InspectorAgent.cpp', u'Source/WebCore/inspector/InspectorCanvasAgent.cpp', u'Source/WebCore/inspector/InspectorClient.cpp', u'Source/WebCore/inspector/InspectorController.cpp', u'Source/WebCore/inspector/InspectorDOMAgent.cpp', u'Source/WebCore/inspector/InspectorFrontendClientLocal.cpp', u'Source/WebCore/inspector/InspectorFrontendHost.cpp', u'Source/WebCore/inspector/InspectorInputAgent.cpp', u'Source/WebCore/inspector/InspectorInstrumentation.cpp', u'Source/WebCore/inspector/InspectorOverlay.cpp', u'Source/WebCore/inspector/InspectorPageAgent.cpp', u'Source/WebCore/inspector/PageRuntimeAgent.cpp', u'Source/WebCore/loader/FrameLoader.cpp', u'Source/WebCore/loader/HistoryController.cpp', u'Source/WebCore/loader/archive/mhtml/MHTMLArchive.cpp', u'Source/WebCore/page/Chrome.cpp', u'Source/WebCore/page/ContextMenuController.cpp', u'Source/WebCore/page/DOMWindow.cpp', u'Source/WebCore/page/DragController.cpp', u'Source/WebCore/page/EventHandler.cpp', u'Source/WebCore/page/FocusController.cpp', u'Source/WebCore/page/Frame.cpp', u'Source/WebCore/page/FrameTree.cpp', u'Source/WebCore/page/FrameView.cpp', u'Source/WebCore/page/Page.cpp', u'Source/WebCore/page/Page.h', u'Source/WebCore/page/PageGroup.cpp', u'Source/WebCore/page/PageGroupLoadDeferrer.cpp', u'Source/WebCore/page/PageSerializer.cpp', u'Source/WebCore/page/PageThrottler.cpp', u'Source/WebCore/page/Settings.cpp', u'Source/WebCore/page/SpatialNavigation.cpp', u'Source/WebCore/page/mac/DragControllerMac.mm', u'Source/WebCore/page/scrolling/ScrollingCoordinator.cpp', u'Source/WebCore/page/scrolling/mac/ScrollingCoordinatorMac.mm', u'Source/WebCore/platform/graphics/texmap/coordinated/CompositingCoordinator.cpp', u'Source/WebCore/plugins/DOMMimeType.cpp', u'Source/WebCore/rendering/RenderBox.cpp', u'Source/WebCore/rendering/RenderLayerBacking.cpp', u'Source/WebCore/rendering/TextAutosizer.cpp', u'Source/WebCore/storage/StorageEventDispatcher.cpp', u'Source/WebCore/svg/graphics/SVGImage.cpp', u'Source/WebCore/testing/InternalSettings.cpp', u'Source/WebCore/testing/Internals.cpp', u'Source/WebKit/efl/WebCoreSupport/AcceleratedCompositingContextEfl.cpp', u'Source/WebKit/efl/WebCoreSupport/InspectorClientEfl.cpp', u'Source/WebKit/efl/ewk/ewk_view.cpp', u'Source/WebKit/gtk/WebCoreSupport/AcceleratedCompositingContextGL.cpp', u'Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp', u'Source/WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp', u'Source/WebKit/gtk/WebCoreSupport/GtkAdjustmentWatcher.cpp', u'Source/WebKit/gtk/webkit/webkitviewportattributes.cpp', u'Source/WebKit/gtk/webkit/webkitwebframe.cpp', u'Source/WebKit/gtk/webkit/webkitwebview.cpp', u'Source/WebKit/mac/WebCoreSupport/WebDragClient.mm', u'Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm', u'Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm', u'Source/WebKit/mac/WebCoreSupport/WebPlatformStrategies.mm', u'Source/WebKit/mac/WebView/WebFrame.mm', u'Source/WebKit/mac/WebView/WebFrameView.mm', u'Source/WebKit/mac/WebView/WebHTMLView.mm', u'Source/WebKit/mac/WebView/WebView.mm', u'Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.cpp', u'Source/WebKit/win/WebView.cpp', u'Source/WebKit/wince/WebView.cpp', u'Source/WebKit2/WebProcess/FullScreen/WebFullScreenManager.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp', u'Source/WebKit2/WebProcess/Plugins/PluginView.cpp', u'Source/WebKit2/WebProcess/Storage/StorageAreaMap.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebContextMenuClient.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm', u'Source/WebKit2/WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm', u'Source/WebKit2/WebProcess/WebPage/FindController.cpp', u'Source/WebKit2/WebProcess/WebPage/PageOverlay.cpp', u'Source/WebKit2/WebProcess/WebPage/WebInspector.cpp', u'Source/WebKit2/WebProcess/WebPage/WebPage.cpp', u'Source/WebKit2/WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp', u'Source/WebKit2/WebProcess/WebPage/mac/LayerTreeHostMac.mm', u'Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeContext.mm', u'Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm', u'Source/WebKit2/WebProcess/WebPage/mac/WKAccessibilityWebPageObject.mm', u'Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm']" exit_code: 1
Source/WebKit/gtk/webkit/webkitwebview.cpp:4393:  Declaration has space between type name and * in Frame *frame  [whitespace/declaration] [3]
Total errors found: 1 in 98 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 15 Early Warning System Bot 2013-08-26 18:13:26 PDT

Comment on attachment 209699 [details]
Patch for landing (if EWS likes)

Attachment 209699 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1583089

Comment 16 Early Warning System Bot 2013-08-26 18:14:46 PDT

Comment on attachment 209699 [details]
Patch for landing (if EWS likes)

Attachment 209699 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1592076

Comment 17 EFL EWS Bot 2013-08-26 18:18:47 PDT

Comment on attachment 209699 [details]
Patch for landing (if EWS likes)

Attachment 209699 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/1588094

Comment 18 kov's GTK+ EWS bot 2013-08-26 18:23:20 PDT

Comment on attachment 209699 [details]
Patch for landing (if EWS likes)

Attachment 209699 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/1580112

Comment 19 EFL EWS Bot 2013-08-26 18:24:21 PDT

Comment on attachment 209699 [details]
Patch for landing (if EWS likes)

Attachment 209699 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/1578118

Comment 20 Andreas Kling 2013-08-26 18:25:16 PDT

Created attachment 209702 [details]
Patch for landing (come on, EWS, let's be friends)

Comment 21 Early Warning System Bot 2013-08-26 18:30:12 PDT

Comment on attachment 209702 [details]
Patch for landing (come on, EWS, let's be friends)

Attachment 209702 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1592081

Comment 22 Early Warning System Bot 2013-08-26 18:33:35 PDT

Comment on attachment 209702 [details]
Patch for landing (come on, EWS, let's be friends)

Attachment 209702 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1584107

Comment 23 EFL EWS Bot 2013-08-26 18:34:54 PDT

Comment on attachment 209702 [details]
Patch for landing (come on, EWS, let's be friends)

Attachment 209702 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/1586098

Comment 24 EFL EWS Bot 2013-08-26 18:38:19 PDT

Comment on attachment 209702 [details]
Patch for landing (come on, EWS, let's be friends)

Attachment 209702 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/1601002

Comment 25 Andreas Kling 2013-08-26 18:38:49 PDT

Created attachment 209704 [details]
Patch for landing (ews pls)

Comment 26 Early Warning System Bot 2013-08-26 18:45:28 PDT

Comment on attachment 209704 [details]
Patch for landing (ews pls)

Attachment 209704 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1586102

Comment 27 Early Warning System Bot 2013-08-26 18:46:23 PDT

Comment on attachment 209704 [details]
Patch for landing (ews pls)

Attachment 209704 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1589098

Comment 28 Andreas Kling 2013-08-26 18:48:14 PDT

Created attachment 209705 [details]
Patch for landing (totally...)

Comment 29 Early Warning System Bot 2013-08-26 19:02:49 PDT

Comment on attachment 209705 [details]
Patch for landing (totally...)

Attachment 209705 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1585114

Comment 30 Early Warning System Bot 2013-08-26 19:05:34 PDT

Comment on attachment 209705 [details]
Patch for landing (totally...)

Attachment 209705 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1585117

Comment 31 Andreas Kling 2013-08-26 19:21:18 PDT

Created attachment 209707 [details]
Patch for landing (!)

Comment 32 Andreas Kling 2013-08-26 20:03:07 PDT

Committed r154658: <http://trac.webkit.org/changeset/154658>

Comment 33 Ryosuke Niwa 2013-08-26 20:38:05 PDT

Windows build fixed in http://trac.webkit.org/changeset/154659 and http://trac.webkit.org/changeset/154659

aboxhall
andersca
apinheiro
cdumez
cfleizach
cmarcelo
commit-queue
dmazzoni
d-r
eflews.bot
eric.carlson
esprehn+autocc
fmalita
glenn
gtk-ews
gyuyoung.kim
jamesr
japhet
jdiggs
jer.noble
kangil.han
kling
kondapallykalyan
luiz
macpherson
mario
menard
noam
pdr
rakuco
rego+ews
rniwa
schenney
simon.fraser
tonikitoo
webkit-ews
xan.lopez