ANGLE fails to build with trunk clang. Errors are due to the 'register' keyword being deprecated: glslang_lex.cpp:2033:2: error: 'register' storage class specifier is deprecated [-Werror,-Wdeprecated-register] Tokenizer.cpp:788:2: error: 'register' storage class specifier is deprecated [-Werror,-Wdeprecated-register]
<rdar://problem/14763822>
Created attachment 208974 [details] Patch v1
Comment on attachment 208974 [details] Patch v1 Removed r? status. I'm not sure how this passed the EWS bots as it should have generated an error about an unknown pragma.
Created attachment 208980 [details] Patch v2
Comment on attachment 208980 [details] Patch v2 Tempting to just get rid of all those "register", but I guess we want to make this easier to merge with future versions of ANGLE. Are you contributing this to the upstream ANGLE too?
Comment on attachment 208980 [details] Patch v2 Clearing flags on attachment: 208980 Committed r154223: <http://trac.webkit.org/changeset/154223>
All reviewed patches have been landed. Closing bug.
(In reply to comment #5) > (From update of attachment 208980 [details]) > Tempting to just get rid of all those "register", but I guess we want to make this easier to merge with future versions of ANGLE. The bigger concern is that the 'register' keywords are in generated code from flex, so we really don't want to be in the business of remembering to modify the generated source code every time. > Are you contributing this to the upstream ANGLE too? Yes, insomuch as that's possible (which means I filed a bug and pointed it back here): <http://code.google.com/p/angleproject/issues/detail?id=463>