Bug 119935 - WebKit2 fails to build with trunk clang: error: 'WebPluginSiteDataManagerh' is used as a header guard here, followed by #define of a different macro [-Werror,-Wheader-guard]
Summary: WebKit2 fails to build with trunk clang: error: 'WebPluginSiteDataManagerh' i...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-08-16 22:19 PDT by David Kilzer (:ddkilzer)
Modified: 2013-08-17 05:36 PDT (History)
7 users (show)

See Also:

Attachments
Patch v1 (1.39 KB, patch)
2013-08-16 22:25 PDT, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2013-08-16 22:19:44 PDT 
Trunk clang has some really cool new checks:

In file included from WebKit.git/Source/WebKit2/UIProcess/Plugins/PluginProcessProxy.cpp:37:
WebKit.git/Source/WebKit2/UIProcess/Plugins/WebPluginSiteDataManager.h:26:9: error: 'WebPluginSiteDataManagerh' is used as a header guard here, followed by #define of a different macro [-Werror,-Wheader-guard]
#ifndef WebPluginSiteDataManagerh
        ^~~~~~~~~~~~~~~~~~~~~~~~~
WebKit.git/Source/WebKit2/UIProcess/Plugins/WebPluginSiteDataManager.h:27:9: note: 'WebPluginSiteDataManager_h' is defined here; did you mean 'WebPluginSiteDataManagerh'?
#define WebPluginSiteDataManager_h
        ^~~~~~~~~~~~~~~~~~~~~~~~~~
        WebPluginSiteDataManagerh
1 error generated.
Comment 1 David Kilzer (:ddkilzer) 2013-08-16 22:20:27 PDT 
<rdar://problem/14764131>
Comment 2 David Kilzer (:ddkilzer) 2013-08-16 22:25:04 PDT 
Created attachment 208978 [details]
Patch v1
Comment 3 WebKit Commit Bot 2013-08-17 05:35:58 PDT 
Comment on attachment 208978 [details]
Patch v1

Clearing flags on attachment: 208978

Committed r154222: <http://trac.webkit.org/changeset/154222>
Comment 4 WebKit Commit Bot 2013-08-17 05:36:00 PDT 
All reviewed patches have been landed.  Closing bug.