Bug 120183 - WebCore fails to link due to changes in Objective-C++ ABI in trunk clang
Summary: WebCore fails to link due to changes in Objective-C++ ABI in trunk clang
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on:
Blocks: 126958
  Show dependency treegraph
 
Reported: 2013-08-22 17:14 PDT by David Kilzer (:ddkilzer)
Modified: 2014-01-13 20:18 PST (History)
9 users (show)

See Also:


Attachments
Patch v1 (2.47 KB, patch)
2013-08-22 17:19 PDT, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2013-08-22 17:14:38 PDT
The trunk version of clang made an ABI change for Objective-C++ parameters that caused WebCore to fail to link.  The short-term fix is to change the parameter type from id<protocol> to just id and add an ASSERT that the parameter still conforms to the protocol.
Comment 1 David Kilzer (:ddkilzer) 2013-08-22 17:15:38 PDT
<rdar://problem/14764114>
Comment 2 David Kilzer (:ddkilzer) 2013-08-22 17:19:20 PDT
Created attachment 209409 [details]
Patch v1
Comment 3 WebKit Commit Bot 2013-08-23 09:55:27 PDT
Comment on attachment 209409 [details]
Patch v1

Clearing flags on attachment: 209409

Committed r154493: <http://trac.webkit.org/changeset/154493>
Comment 4 WebKit Commit Bot 2013-08-23 09:55:30 PDT
All reviewed patches have been landed.  Closing bug.