Bug 126839 - REGRESSION(r160806): line-height is not applied when only present in :link style.
Summary: REGRESSION(r160806): line-height is not applied when only present in :link st...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-01-12 04:33 PST by Andreas Kling
Modified: 2014-01-12 10:51 PST (History)
8 users (show)

See Also:

Attachments
Patch (1.49 KB, patch)
2014-01-12 04:36 PST, Andreas Kling 		no flags Details | Formatted Diff | Diff
Patch (3.76 KB, patch)
2014-01-12 04:37 PST, Andreas Kling 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2014-01-12 04:33:35 PST 
<rdar://problem/15799899>
Comment 1 Andreas Kling 2014-01-12 04:36:56 PST 
Created attachment 220966 [details]
Patch
Comment 2 Andreas Kling 2014-01-12 04:37:36 PST 
Created attachment 220967 [details]
Patch
Comment 3 Antti Koivisto 2014-01-12 05:11:20 PST 
Comment on attachment 220967 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220967&action=review

> Source/WebCore/css/StyleResolver.cpp:4255
> +        if (auto value = state.style()->insideLink() == NotInsideLink ? cssValue[0] : cssValue[SelectorChecker::MatchLink])

cssValue indexing by LinkMatchMask is pretty incomprehensible. It might be better to just have separate variables (cssValue/linkCSSValue/visitedCSSValue or similar).
Comment 4 Andreas Kling 2014-01-12 10:22:26 PST 
(In reply to comment #3)
> (From update of attachment 220967 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=220967&action=review
> 
> > Source/WebCore/css/StyleResolver.cpp:4255
> > +        if (auto value = state.style()->insideLink() == NotInsideLink ? cssValue[0] : cssValue[SelectorChecker::MatchLink])
> 
> cssValue indexing by LinkMatchMask is pretty incomprehensible. It might be better to just have separate variables (cssValue/linkCSSValue/visitedCSSValue or similar).

Yeah, I agree. Let's keep this fix surgical and sort that in a separate change though.
Comment 5 WebKit Commit Bot 2014-01-12 10:51:28 PST 
Comment on attachment 220967 [details]
Patch

Clearing flags on attachment: 220967

Committed r161814: <http://trac.webkit.org/changeset/161814>
Comment 6 WebKit Commit Bot 2014-01-12 10:51:30 PST 
All reviewed patches have been landed.  Closing bug.