Bug 128045 - Saying "jitType() == JITCode::DFGJIT" is almost never correct
Summary: Saying "jitType() == JITCode::DFGJIT" is almost never correct
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Mark Lam
URL:
Keywords:
Depends on:
Blocks: 112840
  Show dependency tree / graph
 
Reported: 2014-02-01 11:14 PST by Filip Pizlo
Modified: 2014-02-01 12:26 PST (History)
9 users (show)

See Also:

Attachments
the patch. (2.16 KB, patch)
2014-02-01 12:15 PST, Mark Lam 		fpizlo: review+
Details | Formatted Diff | Diff
Oops missing a ')'. Here's the fixed patch for landing. (2.16 KB, patch)
2014-02-01 12:22 PST, Mark Lam 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2014-02-01 11:14:42 PST 
JITCode::isOptimizingJIT(jitType()) is the right way to say it.

There is at least one place in the profiling/debugging code where we make this mistake.
Comment 1 Mark Lam 2014-02-01 11:59:51 PST 
(In reply to comment #0)
> JITCode::isOptimizingJIT(jitType()) is the right way to say it.
> 
> There is at least one place in the profiling/debugging code where we make this mistake.

That was deliberate because it was assumed that we would have never optimized to the FTL tier if the debugger or profiler is enabled.  But I’ll be changing it anyway because we’ll want to enable the FTL as well soon.
Comment 2 Mark Lam 2014-02-01 12:15:35 PST 
Created attachment 222885 [details]
the patch.
Comment 3 Mark Lam 2014-02-01 12:22:30 PST 
Created attachment 222886 [details]
Oops missing a ')'.  Here's the fixed patch for landing.
Comment 4 Mark Lam 2014-02-01 12:26:39 PST 
Thanks.  Landed in r163247: <http://trac.webkit.org/r163247>.