Bug 128485 - [ASan] Fix build failures in Tools due to missing $(inherited) values
Summary: [ASan] Fix build failures in Tools due to missing $(inherited) values
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-08 20:32 PST by David Kilzer (:ddkilzer)
Modified: 2014-02-11 12:07 PST (History)
6 users (show)

See Also:


Attachments
Patch v1 (6.66 KB, patch)
2014-02-08 20:41 PST, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2014-02-08 20:32:57 PST
When iOS changes were upstreamed or tools were made to build for iOS, the $(inherited) value was lost in OTHER_LDFLAGS in some *.xcconfig files that was required to make the tools build with the clang address sanitizer enabled.
Comment 1 David Kilzer (:ddkilzer) 2014-02-08 20:41:34 PST
Created attachment 223603 [details]
Patch v1
Comment 2 WebKit Commit Bot 2014-02-11 12:07:29 PST
Comment on attachment 223603 [details]
Patch v1

Clearing flags on attachment: 223603

Committed r163894: <http://trac.webkit.org/changeset/163894>
Comment 3 WebKit Commit Bot 2014-02-11 12:07:32 PST
All reviewed patches have been landed.  Closing bug.