Bug 128871 - [ASan] WebKit1 sources are not compiled using ASAN macros
Summary: [ASan] WebKit1 sources are not compiled using ASAN macros
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-15 07:04 PST by David Kilzer (:ddkilzer)
Modified: 2014-02-22 09:27 PST (History)
4 users (show)

See Also:

Attachments
Patch v1 (2.76 KB, patch)
2014-02-15 07:06 PST, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2014-02-15 07:04:51 PST 
The way the OTHER_CPLUSPLUSFLAGS variable is defined in WebKit.xcconfig doesn't include ASAN_OTHER_CPLUSPLUSFLAGS set in DebugRelease.xcconfig, so not all files are compiled with ASan enabled in WebKit1.
Comment 1 David Kilzer (:ddkilzer) 2014-02-15 07:06:50 PST 
Created attachment 224298 [details]
Patch v1
Comment 2 Brent Fulgham 2014-02-19 11:37:08 PST 
Comment on attachment 224298 [details]
Patch v1

r=me
Comment 3 WebKit Commit Bot 2014-02-20 10:10:27 PST 
Comment on attachment 224298 [details]
Patch v1

Clearing flags on attachment: 224298

Committed r164434: <http://trac.webkit.org/changeset/164434>
Comment 4 WebKit Commit Bot 2014-02-20 10:10:30 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 David Kilzer (:ddkilzer) 2014-02-22 09:27:42 PST 
(In reply to comment #3)
> (From update of attachment 224298 [details])
> Clearing flags on attachment: 224298
> 
> Committed r164434: <http://trac.webkit.org/changeset/164434>

This change was reverted in r164542:  <http://trac.webkit.org/changeset/164542>

It actually broke ASan builds when specifying "ARGS=-xcconfig Tools/asan/asan.xcconfig" on the build command-line.