Uninit Error reported from write at IPC::Channel::ChannelImpl::ProcessOutgoingMessages <https://code.google.com/p/chromium/issues/detail?id=342591> Code Review: <https://codereview.chromium.org/177633011/>
<rdar://problem/16383151>
Created attachment 227436 [details] Patch v1
Comment on attachment 227436 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=227436&action=review I’m saying review+ but this change doesn’t seem to have much benefit. > Source/WebCore/ChangeLog:13 > + - Initialize x, y, width, height in String constructor. Why? To make automated code analysis tools happy? To actually fix a bug? Where’s the test case for the bug?
(In reply to comment #3) > (From update of attachment 227436 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=227436&action=review > > I’m saying review+ but this change doesn’t seem to have much benefit. > > > Source/WebCore/ChangeLog:13 > > + - Initialize x, y, width, height in String constructor. > > Why? To make automated code analysis tools happy? To actually fix a bug? Where’s the test case for the bug? It's to make code analysis tools happy.
Comment on attachment 227436 [details] Patch v1 Clearing flags on attachment: 227436 Committed r166072: <http://trac.webkit.org/changeset/166072>
All reviewed patches have been landed. Closing bug.