Bug 130609 - fix-blink-commit: new script to fix up renamed directory paths
Summary: fix-blink-commit: new script to fix up renamed directory paths
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-21 10:56 PDT by David Kilzer (:ddkilzer)
Modified: 2014-03-21 11:56 PDT (History)
4 users (show)

See Also:

Attachments
Patch v1 (2.83 KB, patch)
2014-03-21 11:11 PDT, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2014-03-21 10:56:20 PDT 
I created a tiny tool that just fixes up Blink directory paths in patches so they match back up with WebKit.

We could add class renames to this as well if we find it useful.

Nominal use:  cat blink.patch | fix-blink-patch | svn-apply
Comment 1 David Kilzer (:ddkilzer) 2014-03-21 11:09:49 PDT 
Hmm, I wonder if adding a "--blink" switch to svn-apply would be better:

cat blink.patch | svn-apply --blink
Comment 2 David Kilzer (:ddkilzer) 2014-03-21 11:11:15 PDT 
Created attachment 227462 [details]
Patch v1
Comment 3 David Kilzer (:ddkilzer) 2014-03-21 11:21:21 PDT 
(In reply to comment #1)
> Hmm, I wonder if adding a "--blink" switch to svn-apply would be better:
> 
> cat blink.patch | svn-apply --blink

I think I want to hold off on this for now since svn-apply doesn't parse the patches itself--it calls parsePatch() in VCSUtils.pm, so there isn't a clear place to do it in svn-apply.
Comment 4 WebKit Commit Bot 2014-03-21 11:56:51 PDT 
Comment on attachment 227462 [details]
Patch v1

Clearing flags on attachment: 227462

Committed r166081: <http://trac.webkit.org/changeset/166081>
Comment 5 WebKit Commit Bot 2014-03-21 11:56:54 PDT 
All reviewed patches have been landed.  Closing bug.