Bug 131540 - [GTK] Add support for text-decoration-skip
Summary: [GTK] Add support for text-decoration-skip
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Linux
: P2 Normal
Assignee: Martin Robinson
URL:
Keywords:
Depends on: 139578
Blocks:
  Show dependency tree / graph
 
Reported: 2014-04-11 08:47 PDT by Carlos Alberto Lopez Perez
Modified: 2014-12-12 00:39 PST (History)
6 users (show)

See Also:

Attachments
Patch (16.87 KB, patch)
2014-12-10 08:36 PST, Martin Robinson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Alberto Lopez Perez 2014-04-11 08:47:58 PDT 
The following layout test is failing on platform GTK

fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-ink-svg.html

The failure started to happen on r166902 <http://trac.webkit.org/r166902>.
I tested r166901 and the tests passes. From r166902 ahead the test fails.

The diff is:

http://build.webkit.org/results/GTK%20Linux%2064-bit%20Release/r166911%20%2846234%29/fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-ink-svg-diffs.html
Comment 1 Martin Robinson 2014-04-11 08:59:49 PDT 
Look like we need an implementation like what was added in: https://bugs.webkit.org/show_bug.cgi?id=128936
Comment 2 Martin Robinson 2014-12-10 08:36:50 PST 
Created attachment 243025 [details]
Patch
Comment 3 Gustavo Noronha (kov) 2014-12-10 10:08:50 PST 
Comment on attachment 243025 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=243025&action=review

LGTM =)

> LayoutTests/platform/gtk/TestExpectations:1949
>  webkit.org/b/124507 fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-ink.html [ ImageOnlyFailure ]

This was also not fixed?
Comment 4 Martin Robinson 2014-12-10 10:29:26 PST 
(In reply to comment #3)
> Comment on attachment 243025 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=243025&action=review
> 
> LGTM =)
> 
> > LayoutTests/platform/gtk/TestExpectations:1949
> >  webkit.org/b/124507 fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-ink.html [ ImageOnlyFailure ]
> 
> This was also not fixed?

No, I think this is also a subpixel positioning issue.
Comment 5 Martin Robinson 2014-12-10 10:37:06 PST 
Comment on attachment 243025 [details]
Patch

Clearing flags on attachment: 243025

Committed r177078: <http://trac.webkit.org/changeset/177078>
Comment 6 Martin Robinson 2014-12-10 10:37:15 PST 
All reviewed patches have been landed.  Closing bug.