The grid property is a shorthand that sets all of the explicit grid properties (grid-template-rows, grid-template-columns, and grid-template-areas) as well as all the implicit grid properties (grid-auto-rows, grid-auto-columns, and grid-auto-flow) in a single declaration.
Created attachment 230078 [details] Patch
Comment on attachment 230078 [details] Patch EWS was unable to apply the patch. I suggest rebasing and uploading a new one.
(In reply to comment #2) > (From update of attachment 230078 [details]) > EWS was unable to apply the patch. I suggest rebasing and uploading a new one. The problem is that it highly depends on bug #12898, so it'd be great if you or someone else could review it.
(In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 230078 [details] [details]) > > EWS was unable to apply the patch. I suggest rebasing and uploading a new one. > > The problem is that it highly depends on bug #12898, so it'd be great if you or someone else could review it. Sorry, I meant it depends on the patch for the bug #128980.
Created attachment 230176 [details] Patch Patch rebased.
Now that the "grid-template" shorthand has been implemented, perhaps someone could review this patch.
Comment on attachment 230176 [details] Patch clearing flags because probably this patch is affected by the cause of the regression indentified in bug #132194
Created attachment 230607 [details] Patch Patch rebased to use the enhanced version of the grid-template shorthand. I've also introduced the changes required to avoid the regression identified in bug #132194
ping reviewers.
Comment on attachment 230607 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=230607&action=review Quick comments. > Source/WebCore/css/CSSParser.cpp:4942 > + RefPtr<CSSValue> autoColumnsValue = nullptr; > + RefPtr<CSSValue> autoRowsValue = nullptr; No need for = nullptr. RefPtr is initialized like that. > LayoutTests/fast/css-grid-layout/grid-shorthand-get-set.html:36 > +/* Bad values. */ > + > +#gridWithExplicitAndImplicit { > + -webkit-grid: 10px / 20px column; > +} > +#gridWithMisplacedNone1 { > + -webkit-grid: column 10px / none 20px; > +} > +#gridWithMisplacedNone2 { > + -webkit-grid: 10px / 20px none; > +} That's very little coverage for bad cases.
Created attachment 231871 [details] Patch Patch rebased and applied suggested changes.
Comment on attachment 231871 [details] Patch Clearing flags on attachment: 231871 Committed r169349: <http://trac.webkit.org/changeset/169349>
All reviewed patches have been landed. Closing bug.