Bug 134343 - DFG::FunctionWhitelist::parseFunctionNamesInFile does not close file
Summary: DFG::FunctionWhitelist::parseFunctionNamesInFile does not close file
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-06-26 01:20 PDT by David Kilzer (:ddkilzer)
Modified: 2014-06-26 08:30 PDT (History)
8 users (show)

See Also:


Attachments
Patch v1 (1.44 KB, patch)
2014-06-26 01:22 PDT, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2014-06-26 01:20:34 PDT
DFG::FunctionWhitelist::parseFunctionNamesInFile returns without calling fclose(f), so the file descriptor leaks.
Comment 1 David Kilzer (:ddkilzer) 2014-06-26 01:20:46 PDT
<rdar://problem/17459487>
Comment 2 David Kilzer (:ddkilzer) 2014-06-26 01:22:56 PDT
Created attachment 233892 [details]
Patch v1
Comment 3 WebKit Commit Bot 2014-06-26 08:30:47 PDT
Comment on attachment 233892 [details]
Patch v1

Clearing flags on attachment: 233892

Committed r170480: <http://trac.webkit.org/changeset/170480>
Comment 4 WebKit Commit Bot 2014-06-26 08:30:51 PDT
All reviewed patches have been landed.  Closing bug.