Bug 134993 - [iOS] Update order file paths for WebKit and WebKit2
Summary: [iOS] Update order file paths for WebKit and WebKit2
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-07-16 16:30 PDT by David Kilzer (:ddkilzer)
Modified: 2014-07-16 20:18 PDT (History)
9 users (show)

See Also:


Attachments
Patch v1 (2.90 KB, patch)
2014-07-16 17:08 PDT, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2014-07-16 16:30:15 PDT
Need to update the order files for WebKit and WebKit2 for iOS.
Comment 1 David Kilzer (:ddkilzer) 2014-07-16 16:30:32 PDT
<rdar://problem/17557776>
Comment 2 David Kilzer (:ddkilzer) 2014-07-16 17:08:40 PDT
Created attachment 235036 [details]
Patch v1
Comment 3 WebKit Commit Bot 2014-07-16 18:38:27 PDT
Comment on attachment 235036 [details]
Patch v1

Clearing flags on attachment: 235036

Committed r171164: <http://trac.webkit.org/changeset/171164>
Comment 4 WebKit Commit Bot 2014-07-16 18:38:30 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 mitz 2014-07-16 18:40:38 PDT
Not new to this patch, but I’d like to understand why this is specified in Base.xcconfig rather than in the configuration for the target that builds the framework.
Comment 6 David Kilzer (:ddkilzer) 2014-07-16 20:18:56 PDT
(In reply to comment #5)
> Not new to this patch, but I’d like to understand why this is specified in Base.xcconfig rather than in the configuration for the target that builds the framework.

The only reason I can think of doing it in the Base.xcconfig is that it's easy to override (to no order file) for Debug/Release builds.

However, I don't know of any downsides to specifying an order file in Debug/Release, unless it makes link times significantly longer.

I filed Bug 135006.