Bug 136600 - HTMLElement.cpp does not compile with new clang
Summary: HTMLElement.cpp does not compile with new clang
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-06 07:00 PDT by David Kilzer (:ddkilzer)
Modified: 2014-09-06 08:03 PDT (History)
9 users (show)

See Also:

Attachments
Patch v1 (1.69 KB, patch)
2014-09-06 07:03 PDT, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2014-09-06 07:00:50 PDT 
HTMLElement.cpp fails to build with new clang:

Source/WebCore/html/HTMLElement.cpp:545:10: error: 'this' pointer cannot be null in well-defined C++ code; pointer may be assumed to always convert to true [-Werror,-Wundefined-bool-conversion]
    if (!this || !parentNode())
        ~^~~~
1 error generated.

The |!this| check was added in <http://trac.webkit.org/r75738>.
Comment 1 David Kilzer (:ddkilzer) 2014-09-06 07:03:15 PDT 
Created attachment 237736 [details]
Patch v1
Comment 2 WebKit Commit Bot 2014-09-06 08:03:14 PDT 
Comment on attachment 237736 [details]
Patch v1

Clearing flags on attachment: 237736

Committed r173355: <http://trac.webkit.org/changeset/173355>
Comment 3 WebKit Commit Bot 2014-09-06 08:03:18 PDT 
All reviewed patches have been landed.  Closing bug.