Bug 138640 - Modernize $buildingForIPhone in CodeGeneratorObjC.pm
Summary: Modernize $buildingForIPhone in CodeGeneratorObjC.pm
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-11-11 16:39 PST by David Kilzer (:ddkilzer)
Modified: 2014-11-12 09:35 PST (History)
4 users (show)

See Also:

Attachments
Patch v1 (4.02 KB, patch)
2014-11-11 16:43 PST, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2014-11-11 16:39:45 PST 
Mac OS X is the only platform that supports NSColor, so rename $buildingForIPhone to $shouldUseCGColor (which is actually what the variable represents) and define it in terms of the "macosx" platform name.
Comment 1 David Kilzer (:ddkilzer) 2014-11-11 16:43:26 PST 
Created attachment 241394 [details]
Patch v1
Comment 2 David Kilzer (:ddkilzer) 2014-11-11 16:48:03 PST 
<rdar://problem/18919000>
Comment 3 Daniel Bates 2014-11-11 17:06:56 PST 
Comment on attachment 241394 [details]
Patch v1

OK.
Comment 4 Mark Rowe (bdash) 2014-11-11 17:07:04 PST 
Comment on attachment 241394 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=241394&action=review

> Source/WebCore/ChangeLog:3
> +        Modernize $buildingForIPhone in CodeGeneratorObjC.pm

"Modernize" is a strange way of saying "rename".
Comment 5 WebKit Commit Bot 2014-11-11 17:20:35 PST 
Comment on attachment 241394 [details]
Patch v1

Clearing flags on attachment: 241394

Committed r175995: <http://trac.webkit.org/changeset/175995>
Comment 6 WebKit Commit Bot 2014-11-11 17:20:39 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 David Kilzer (:ddkilzer) 2014-11-12 09:35:50 PST 
(In reply to comment #4)
> Comment on attachment 241394 [details]
> Patch v1
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=241394&action=review
> 
> > Source/WebCore/ChangeLog:3
> > +        Modernize $buildingForIPhone in CodeGeneratorObjC.pm
> 
> "Modernize" is a strange way of saying "rename".

That's because it wasn't just a variable rename; I changed the logic of how the variable was defined and removed some cruft.