Bug 144395 - check-webkit-style: Don't complain about returning value from Objective-C method call in header
Summary: check-webkit-style: Don't complain about returning value from Objective-C met...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-29 10:07 PDT by David Kilzer (:ddkilzer)
Modified: 2015-04-29 12:34 PDT (History)
9 users (show)

See Also:

Attachments
Patch v1 (4.75 KB, patch)
2015-04-29 10:19 PDT, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2015-04-29 10:07:27 PDT 
In Bug 144362, an inline method was added to SoftLinking.h that returned the value from an Objective-C method call:

+    inline className *alloc##className##Instance() \
+    { \
+        return [get_##framework##_##className##Class() alloc]; \
+    } \

However, check-webkit-style incorrectly flagged this as a style issue (see Bug 144362, Comment #24):

ERROR: Source/WebCore/platform/mac/SoftLinking.h:327:  Extra space before [  [whitespace/braces] [5]

Additional issues noted while investigating this:
- The category should be "whitespace/brackets", not "whitespace/braces".
- There is no test coverage for the code that checks for "whitespace/brackets".
Comment 1 David Kilzer (:ddkilzer) 2015-04-29 10:19:15 PDT 
Created attachment 251962 [details]
Patch v1
Comment 2 WebKit Commit Bot 2015-04-29 12:34:10 PDT 
Comment on attachment 251962 [details]
Patch v1

Clearing flags on attachment: 251962

Committed r183567: <http://trac.webkit.org/changeset/183567>
Comment 3 WebKit Commit Bot 2015-04-29 12:34:16 PDT 
All reviewed patches have been landed.  Closing bug.