Bug 148229 - dispatch_group_t objects may not be retained properly when not backed by Objective-C objects under garbage collection
Summary: dispatch_group_t objects may not be retained properly when not backed by Obje...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-20 10:06 PDT by David Kilzer (:ddkilzer)
Modified: 2015-08-21 11:37 PDT (History)
7 users (show)

See Also:

Attachments
Patch (3.54 KB, patch)
2015-08-21 10:35 PDT, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
Patch v2 (3.74 KB, patch)
2015-08-21 10:44 PDT, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2015-08-20 10:06:25 PDT 
dispatch_group_t objects may not be retained properly when not backed by Objective-C objects under garbage collection.

The proper way to address this is to use OSObjectPtr<>, which does the right thing regardless of whether the dispatch_group_t objects are backed by Objective-C objects or not.
Comment 1 David Kilzer (:ddkilzer) 2015-08-21 10:35:12 PDT 
Created attachment 259630 [details]
Patch
Comment 2 David Kilzer (:ddkilzer) 2015-08-21 10:43:15 PDT 
Comment on attachment 259630 [details]
Patch

I forgot to include the header!
Comment 3 David Kilzer (:ddkilzer) 2015-08-21 10:44:54 PDT 
Created attachment 259631 [details]
Patch v2
Comment 4 WebKit Commit Bot 2015-08-21 11:37:40 PDT 
Comment on attachment 259631 [details]
Patch v2

Clearing flags on attachment: 259631

Committed r188761: <http://trac.webkit.org/changeset/188761>
Comment 5 WebKit Commit Bot 2015-08-21 11:37:43 PDT 
All reviewed patches have been landed.  Closing bug.